From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Patrick Hemmer <git@stormcloud9.net>, git@vger.kernel.org
Subject: Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled
Date: Mon, 30 Apr 2018 12:30:57 +0900 [thread overview]
Message-ID: <xmqqzi1lxte6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180430020930.GA13217@genre.crustytoothpaste.net> (brian m. carlson's message of "Mon, 30 Apr 2018 02:09:31 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On Sun, Apr 29, 2018 at 09:40:13PM -0400, Patrick Hemmer wrote:
>> When you use `git format-patch --cover-letter --attach`, the cover
>> letter does not have the trailing MIME boundary. RFC2046 states that the
>> last part must be followed by a closing boundary. This causes some email
>> clients (Thunderbird in my case) to discard the message body.
>> This is experienced with git 2.16.3.
>
> Thanks for reporting this. I can confirm this with a reasonably recent
> next. Let me see if I can come up with a patch.
Thanks. It is true that the current output from the tool is corrupt
mime multi-part, and we need to do something about it.
I however have to wonder if it even makes sense for --cover to pay
attention to --attach and produce the cover template that has "BLURB
HERE" etc. in a multi-part format. Shouldn't we be making a simple
plain text file instead?
next prev parent reply other threads:[~2018-04-30 3:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 1:40 Bug: format-patch MIME boundary not added to cover letter when attach enabled Patrick Hemmer
2018-04-30 2:09 ` brian m. carlson
2018-04-30 3:30 ` Junio C Hamano [this message]
2018-04-30 11:59 ` brian m. carlson
2018-05-01 0:02 ` [PATCH] format-patch: make cover letters always text/plain brian m. carlson
2018-05-01 1:53 ` Eric Sunshine
2018-05-02 0:16 ` brian m. carlson
2018-05-02 2:20 ` [PATCH v2] " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzi1lxte6.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@stormcloud9.net \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).