From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2] test_must_be_empty: simplify file existence check
Date: Tue, 27 Mar 2018 22:20:05 -0700 [thread overview]
Message-ID: <xmqqzi2s93p6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqd0zp9i0d.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 27 Mar 2018 17:10:58 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> test_must_be_empty () {
>> - if ! test -f "$1"
>> - then
>> - echo "'$1' is missing"
>> - return 1
>> - elif test -s "$1"
>> + test_path_is_file "$1" &&
>> + if test -s "$1"
>> then
>> echo "'$1' is not empty, it contains:"
>> cat "$1"
>
> "Just call it" is fine as an idea but
>
> A &&
> if B
> then
> ...
> fi
>
> is somewhat questionable. Shouldn't we make it
>
> if A && B
> then
> ...
> fi
>
> instead?
Nah, you want to treat A's success as a condition *not* to enter the
"then" clause in this case, so my rewrite is bogus. SOrry for the
noise.
prev parent reply other threads:[~2018-03-28 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 11:58 [PATCH] test_must_be_empty: simplify file existence check SZEDER Gábor
2018-03-26 12:48 ` Jeff King
2018-03-26 13:09 ` SZEDER Gábor
2018-03-26 13:11 ` [PATCH v2] " SZEDER Gábor
2018-03-28 0:10 ` Junio C Hamano
2018-03-28 5:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzi2s93p6.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).