Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: marcandre.lureau@redhat.com, git@vger.kernel.org,
	chriscool@tuxfamily.org
Subject: Re: [PATCH] git-bisect: allow running in a working tree subdirectory
Date: Thu, 26 Jan 2017 15:22:50 -0800	[thread overview]
Message-ID: <xmqqziid1k51.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <96afaa1d-31d7-0b7e-d2b3-77a455158638@kdbg.org> (Johannes Sixt's message of "Thu, 26 Jan 2017 22:46:44 +0100")

Johannes Sixt <j6t@kdbg.org> writes:

> Am 26.01.2017 um 19:30 schrieb marcandre.lureau@redhat.com:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> It looks like it can do it.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>>  git-bisect.sh | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/git-bisect.sh b/git-bisect.sh
>> index ae3cb013e..b0bd604d4 100755
>> --- a/git-bisect.sh
>> +++ b/git-bisect.sh
>> @@ -1,5 +1,6 @@
>>  #!/bin/sh
>>
>> +SUBDIRECTORY_OK=Yes
>>  USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|replay|log|run]'
>>  LONG_USAGE='git bisect help
>>  	print this long help message.
>>
>
> Does it also work to drive git bisect from a subdirectory and pass a
> file name (or pathspec) that is relative to that subdirectory rather
> than relative to the root of the worktree? Can `git bisect good` or
> `git bisect bad` of later bisection steps be invoked from different
> subdirectories or the root?

I think the answers are no and no.  Entries in BISECT_NAMES and
BISECT_LOG are not getting any prefix.


      reply	other threads:[~2017-01-26 23:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 18:30 [PATCH] git-bisect: allow running in a working tree subdirectory marcandre.lureau
2017-01-26 18:46 ` Stefan Beller
2017-01-26 19:34   ` Junio C Hamano
2017-01-26 21:46 ` Johannes Sixt
2017-01-26 23:22   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqziid1k51.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=marcandre.lureau@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox