From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Quint Guvernator <quintus.public@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH v5] use starts_with() instead of !memcmp()
Date: Fri, 21 Mar 2014 09:53:18 -0700 [thread overview]
Message-ID: <xmqqzjkjv6gx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cTWV0PWOh88u+rbMPvnn3O+OhTJATEtXXi4oLKUN25Ezw@mail.gmail.com> (Eric Sunshine's message of "Wed, 19 Mar 2014 00:13:13 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Tue, Mar 18, 2014 at 9:18 PM, Quint Guvernator
> <quintus.public@gmail.com> wrote:
>> Another version, this time very in line with the review and commentary of
>> Junio, Eric, and Michael. This version boasts a revamped commit message and
>> fewer but surer hunks changed.
>
> Explaining what changed in this version is indeed a courtesy to
> reviewers. Thanks.
So, is that a "reviewed-by: Eric"?
next prev parent reply other threads:[~2014-03-21 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 1:18 [PATCH v5] use starts_with() instead of !memcmp() Quint Guvernator
2014-03-19 1:18 ` Quint Guvernator
2014-03-19 4:13 ` Eric Sunshine
2014-03-21 16:53 ` Junio C Hamano [this message]
2014-03-21 18:05 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjkjv6gx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=quintus.public@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox