git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Yang <struggleyb.nku@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, trast@student.ethz.ch
Subject: Re: [PATCH 1/2 v2] Add a basic idea section for git-blame.
Date: Sun, 11 Apr 2010 10:23:25 +0800	[thread overview]
Message-ID: <y2l41f08ee11004101923j90709b65mee7c3defb6511246@mail.gmail.com> (raw)
In-Reply-To: <7veiinw0bw.fsf@alter.siamese.dyndns.org>

Hi Junio,

On Sun, Apr 11, 2010 at 3:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
> It doesn't really matter to them _why_ only B is blamed to the parent in
> "A B" -> "B A" movement without -M (and your "BASIC IDEA" section is too
> sketchy for readers to guess why, even if they wanted to learn the
> implementation detail, which they typically don't).
>
> Things like:
>
>    - they can use -M to annotate across block-of-lines swappage within a file;
>    - use of -M adds cost --- it spends extra cycles;
>    - similarly -C annotates across block-of-lines swappage between files;
>    - use -f -C adds larger cost; ...
>
> are the only important things they want to know about, no?

I think all the four things above are mentioned in [PATCH 2/2 v2]
message, it contains who should the command pass blame to and the
order of the algorithm used. Would you please take a look at that
patch?

And the BASIC IDEA section just want to make a basic description about
how blame works briefly. If you thought that it is non-use for
end-users, how about just discard it and make a more technical one at
technical/git-blame.txt ?
Thanks!

Regards!
Bo

  reply	other threads:[~2010-04-11  2:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-10 10:15 [PATCH 0/2 v2] Document update for 'git-blame' '-M' and '-C' option Bo Yang
2010-04-10 10:15 ` [PATCH 1/2 v2] Add a basic idea section for git-blame Bo Yang
2010-04-10 19:53   ` Junio C Hamano
2010-04-11  2:23     ` Bo Yang [this message]
2010-04-11 18:13     ` Pete Harlan
2010-04-10 10:15 ` [PATCH 2/2 v2] Change the description of '-M' and '-C' option Bo Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y2l41f08ee11004101923j90709b65mee7c3defb6511246@mail.gmail.com \
    --to=struggleyb.nku@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).