git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	Giedrius Slavinskas <giedrius.slavinskas@gmail.com>,
	git@vger.kernel.org
Subject: Re: git fast-import crashes importing commits with more than one  author
Date: Sat, 1 May 2010 18:28:44 +0100	[thread overview]
Message-ID: <y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf@mail.gmail.com> (raw)
In-Reply-To: <7vbpcz5ylz.fsf@alter.siamese.dyndns.org>

On 1 May 2010 18:19, Junio C Hamano <gitster@pobox.com> wrote:
> Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> writes:
>
>> On 1 May 2010 17:36, Andreas Schwab <schwab@linux-m68k.org> wrote:
>>> Giedrius Slavinskas <giedrius.slavinskas@gmail.com> writes:
>>>
>>>> git fast-import does not support commits with more than one author. I
>>>> try to import bzr repository and it crashes.
>>>
>>> You can find a patch here:
>>> <http://bazaar.launchpad.net/~schwab-linux-m68k/bzr-fastimport/fastimport.dev/revision/262>
>>>
>>> Andreas.
>>
>> Although this is fine shouldn't we put the additional authors to the
>> signed-off: lines in the git commit message?
>
> If an author didn't sign-off in the log message, a tool shouldn't add it
> automatically.  Doing so makes S-o-b meaningless.
>

Fair enough. I'm justing thinking on how to support round-tripping to
bzr with import/export cause there are a few other properties bzr
needs to recreate identical repository. Is it more appropriate for the
marks format revision (bzr side of it)?

  reply	other threads:[~2010-05-01 17:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-01 15:43 git fast-import crashes importing commits with more than one author Giedrius Slavinskas
2010-05-01 16:36 ` Andreas Schwab
2010-05-01 16:47   ` Dmitrijs Ledkovs
2010-05-01 17:19     ` Junio C Hamano
2010-05-01 17:28       ` Dmitrijs Ledkovs [this message]
2010-05-03  8:59         ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf@mail.gmail.com \
    --to=dmitrij.ledkov@ubuntu.com \
    --cc=giedrius.slavinskas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).