From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eli Collins <eli@cloudera.com>, git@vger.kernel.org
Subject: Re: [PATCH] diff: add a 'path' meta header for non-renames and non-copies
Date: Mon, 3 May 2010 09:37:51 +0200 [thread overview]
Message-ID: <z2m36ca99e91005030037jb880e65w73efa551a53d7be6@mail.gmail.com> (raw)
In-Reply-To: <7viq75tpaw.fsf@alter.siamese.dyndns.org>
On Mon, May 3, 2010 at 09:30, Junio C Hamano <gitster@pobox.com> wrote:
> Sorry, but none of these configuration variables are acceptable as-is.
>
> Many scripts (the ones shipped with core-git, in contrib, or written by
> users) depend on their invocation of "git diff-*" family without any funny
> command line arguments like --no-prefix nor --src-prefix to produce a
> patch that can be applied without giving a custom -p value to "git apply".
>
> Letting the user break that promise is already bad, and not giving the
> scripts any way to protect themselves from these configuration variables
> by overriding from the command line makes these doubly bad ideas.
As far as I understand git_diff_ui_config() applies only for "git
diff" not for any of the plumping "git diff-*" tools. Also I thought
that these extended headers are exactly there to support arbitrary
meta information. Therefore I think your arguments don't hold for my
'path' extended header, do they?
Thanks,
Bert
>
next prev parent reply other threads:[~2010-05-03 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 2:03 [PATCH] diff: add configuration option for disabling diff prefixes Eli Collins
2010-05-03 6:27 ` [PATCH] diff: add a 'path' meta header for non-renames and non-copies Bert Wesarg
2010-05-03 7:30 ` Junio C Hamano
2010-05-03 7:37 ` Bert Wesarg [this message]
2010-05-03 16:29 ` Junio C Hamano
2010-05-03 22:55 ` Bert Wesarg
2010-05-04 1:34 ` Junio C Hamano
2010-05-04 19:30 ` Bert Wesarg
2010-05-05 21:14 ` Eli Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2m36ca99e91005030037jb880e65w73efa551a53d7be6@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=eli@cloudera.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).