From: Albert Dvornik <dvornik+git@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] start_command: close cmd->err descriptor when fork/spawn fails
Date: Mon, 26 Apr 2010 07:47:10 -0400 [thread overview]
Message-ID: <z2n9f74dc2c1004260447y12b522d8if37cad56548738f1@mail.gmail.com> (raw)
In-Reply-To: <4BD53749.6040708@viscovery.net>
On Mon, Apr 26, 2010 at 2:48 AM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Am 4/26/2010 3:15, schrieb bert Dvornik:
[...]
>> I'm not sure why (or if) this problem hasn't cropped up under Linux.
>> The non-Windows code *does* try to check for execve() failures in the
>> child, in addition to the fork() failures.
>
> The problem does show up on Linux if you trigger the right error, such as
> with this patch:
[...]
> + echo "#!/bin/frobnicuty" >testrepo/.git/hooks/pre-receive &&
> + echo exit 1 >>testrepo/.git/hooks/pre-receive &&
Ah, that makes sense! Thank you for clearing up the mystery.
Junio: would you like me to resend with an updated commit message, and
maybe the addition of Hannes's test as well?
--bert
next prev parent reply other threads:[~2010-04-26 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 1:15 [PATCH] start_command: close cmd->err descriptor when fork/spawn fails bert Dvornik
2010-04-26 6:16 ` Johannes Sixt
2010-04-26 6:29 ` Johannes Schindelin
2010-04-26 6:48 ` Johannes Sixt
2010-04-26 11:47 ` Albert Dvornik [this message]
2010-04-26 23:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2n9f74dc2c1004260447y12b522d8if37cad56548738f1@mail.gmail.com \
--to=dvornik+git@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).