From: Alex Riesen <raa.lkml@gmail.com>
To: Will Palmer <wmpalmer@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/3] pretty: add conditional %C?colorname placeholders
Date: Mon, 26 Apr 2010 08:30:55 +0200 [thread overview]
Message-ID: <z2y81b0412b1004252330m189e68bcv19d7d1cb988820b6@mail.gmail.com> (raw)
In-Reply-To: <1272210175-20484-2-git-send-email-wmpalmer@gmail.com>
On Sun, Apr 25, 2010 at 17:42, Will Palmer <wmpalmer@gmail.com> wrote:
> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
> index 1686a54..53eb903 100644
> --- a/Documentation/pretty-formats.txt
> +++ b/Documentation/pretty-formats.txt
> @@ -132,6 +132,7 @@ The placeholders are:
> - '%Cblue': switch color to blue
> - '%Creset': reset color
> - '%C(...)': color specification, as described in color.branch.* config option
> +- '%C?...: switch to specified color, if relevant color.* config option specifies that color is ok
You missed the closing quote character. Besides, how do you think to
distinguish between "%C?diff.color" and "%C?diff.colorcontinuation text"?
The "%C(...)" has a placeholde termination rule (the closing bracket), yours
does not seem to have one (unless something is missing in the documentation).
Ah... I see. Definitely something missing. The spec should be: '%C?(...)'.
next prev parent reply other threads:[~2010-04-26 6:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 15:42 [PATCH 0/3] pretty: format aliases Will Palmer
2010-04-25 15:42 ` [PATCH 1/3] pretty: add conditional %C?colorname placeholders Will Palmer
2010-04-26 6:30 ` Alex Riesen [this message]
[not found] ` <r2o5b9751661004260113m7b6c387bm8467a063c13e5a0f@mail.gmail.com>
2010-04-26 8:20 ` Will Palmer
2010-04-25 15:42 ` [PATCH 2/3] pretty: make %H/%h dependent on --abbrev[-commit] Will Palmer
2010-04-25 15:42 ` [PATCH 3/3] pretty: add aliases for pretty formats Will Palmer
2010-04-25 19:48 ` [PATCH 0/3] pretty: format aliases Jeff King
2010-04-25 20:40 ` Will Palmer
2010-04-25 22:09 ` Jonathan Nieder
2010-04-26 17:22 ` Jeff King
2010-04-26 17:57 ` Jonathan Nieder
2010-04-26 18:07 ` Jeff King
2010-04-26 18:37 ` Jonathan Nieder
2010-04-26 21:14 ` Will Palmer
2010-04-26 22:00 ` Jonathan Nieder
2010-04-27 1:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2y81b0412b1004252330m189e68bcv19d7d1cb988820b6@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).