From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1g8SuW-0007xa-4F for mharc-grub-devel@gnu.org; Fri, 05 Oct 2018 12:25:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g8SuT-0007vo-HF for grub-devel@gnu.org; Fri, 05 Oct 2018 12:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g8SuQ-0004lt-C1 for grub-devel@gnu.org; Fri, 05 Oct 2018 12:25:01 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51326) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g8SuQ-0004h0-2p for grub-devel@gnu.org; Fri, 05 Oct 2018 12:24:58 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w95GJB2i019039; Fri, 5 Oct 2018 16:24:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Xq5/cw4tTCFmyybLb3YdLgEyPCQqpwh1bdB5yjgolYc=; b=Jh8f5cYm8TrhcYFfgUQ/nJqnNHBt8BV2UxmD6b28Pb22ngol3zYOWRbx7yC3dV+E5J3S c7rWlBAxSZJBQBFN61LYzC5fbxgRyj1b8dVkjiDE+9v604v3SdlTGyqdSqt9bOKLg2HJ wcoeqdXjwxR/Mq5zaeieOYrWaoddJuCxr0NNMBmPv9nNeij5cWFqrI+SkJtWIuuphYOS qyQvNW8bhgTZD8o7qCxcoaGitZVY5WN1okUpUMzKZCUe727vV5cNxbMhC4/i5jSO5W7z MGyfTX9UcScd8drnBHV2QoSgHN2HKEjkxVrsjFh2BtAI8yYMYZa0O10tKVvzFMfd1oz9 pg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2mt21rkp5t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Oct 2018 16:24:56 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w95GOo4L031655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 5 Oct 2018 16:24:50 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w95GOnk4027246; Fri, 5 Oct 2018 16:24:49 GMT Received: from [10.152.34.61] (/10.152.34.61) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 05 Oct 2018 16:24:48 +0000 Subject: Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module To: Daniel Kiper , grub-devel@gnu.org Cc: dpsmith.dev@gmail.com, eric.snowberg@oracle.com, javierm@redhat.com, jonmccune@google.com, kanth.ghatraju@oracle.com, keng-yu.lin@hpe.com, konrad.wilk@oracle.com, leif.lindholm@linaro.org, mjg59@srcf.ucam.org, phcoder@gmail.com, philip.b.tricca@intel.com References: <1538559415-6233-1-git-send-email-daniel.kiper@oracle.com> <1538559415-6233-6-git-send-email-daniel.kiper@oracle.com> From: Ross Philipson Openpgp: preference=signencrypt Autocrypt: addr=ross.philipson@oracle.com; keydata= xsBNBFtHZ04BCADHhtvMImplKfIEOytU7ZH4haZ9eFAqZpGeIpG9D+pzTCuReM2/49bvgNoI e1xuiQFO+UEJ8FjedFjDdqY7fSw3xVdX9gLwD1Rmw0Dadc1w6sGbcoOQLHcglesu+BmcKBtU tWQZkzCpEShN4etgZThk8469YnAvO08vNZsrizgrpD90T7mEYiNXxIkX87sPGbnBrL1X7RvZ TaRXfE8174W+XVwGEpSiO/GjRgLW8+DFZB5MgXpCR993+U1YT9Lz97/MRzr4hqcOYry6LBYi s8dOly4oP7gK15oW8Xap9+ur0Jd8Vy8o99Axq+7yunF+2KE2SwP3/w8H3VDpx7EeDhWDABEB AAHNKlJvc3MgUGhpbGlwc29uIDxyb3NzLnBoaWxpcHNvbkBvcmFjbGUuY29tPsLAlAQTAQgA PgIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFsN7r6v0OZTCaJ1wdpHdTZHiMYcBQJb R2eBBQkJZgGzAAoJENpHdTZHiMYcPYcH/Rlp3/F3P4/2i/W0F4yQDVD6rAkejCws4KlbgC5D Slkdvk6j8jOW/HNeIY3n+a3mW0iyyhZlipgYAqkK1loDiDxJjc2eUaHxiYWNLQ4CwIj2EC27 AWCp6hgwHNWmZrdeNbM/Z6LTFQILx5xzgX+86KNqzFV7gOcAaS2qBVz1D83dgrFZaGaao918 nvfe+SnImo0GaEf8nVDKgsD2zfzMBkk4q/E0mrEADFXwBHSvNCnVyrCN6Ve0dHWgI7SszUDt 7v01zbGPR5mRfGuyC9gykd2SDCw5/Q27RMWfaPFL/dtiZBljUzb2yW5jicZAz7zNdDcBSUGR r//wxtG4k/dBrMXOwE0EW0dnTwEIAPelEnLDnfJnHdFR+1Thrvv3Udt/1cjqQfHqH4F8zef/ MsIcPV1skL7qPUYD+CrbasvmqhlPxtJAtN68inPa70fA2g0PtNmLUH1NBb2e6EjOoVZg9ais BWfdYUITZouOXs2zCTFsoNWjTJANnXxexbTf1ZEqfzlVtQK+xAnXl3kiL4Y47VMbgDkGedhw 3ZMWQ2zMMZqYJkPYhtlTXtedhV91DL1347ULwHsvkUJDZ0gL+WU6tYhsCOOiD61x58PfUiFb /WkZEPxb96dSSSWrTlLlBWSSD24RnhfbJjfsXeSu9s4XldmGTDkj7jclMVU1xV0BUfqEwhVn xR8FlC+dZvkAEQEAAcLAfAQYAQgAJgIbDBYhBFsN7r6v0OZTCaJ1wdpHdTZHiMYcBQJbR2eB BQkJZgGyAAoJENpHdTZHiMYcDIAIAIRJrKjIStRvLsOOCX92s9XJPUjrC/xmtVsqVviyFWIC QRPQzDE+bDSvRazudBHmcPW+BOOB5B+p7zKZzOGoZV2peG8oA/Y8oCxOYBtpbBaZ5KJexm/g BbnJUwb3uhmKtDShHGUCmtq8MZBJBr6Q6xHprOU8Qnzs9Jea8NVwaz9O226Rrg4XVv/sK1Lh ++xZfhi7YqKWdx5vdfdnX1xWe8ma0eXLeCDh3V6Ys+Habw1jEbMuafrcVzAbp1rMt2Lju1ls BNAoxeViK7QXWfwGTmGJP++jHmo99gMqEtiohf+37N0oS6uYu6kaE7PxsEcOjWKJxW/DdgwO eFq+D6xuiKk= Message-ID: <0219c5b3-b3c8-3c27-d2d4-ed04dcec3507@oracle.com> Date: Fri, 5 Oct 2018 12:24:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1538559415-6233-6-git-send-email-daniel.kiper@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9037 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810050163 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 16:25:02 -0000 On 10/03/2018 05:36 AM, Daniel Kiper wrote: > Just for clarity. No functional change. > > Signed-off-by: Daniel Kiper > --- > grub-core/Makefile.core.def | 4 +- > grub-core/commands/pgp.c | 1018 +++++++++++++++++++++++++++++++++++++++++++ > grub-core/commands/verify.c | 1018 ------------------------------------------- > 3 files changed, 1020 insertions(+), 1020 deletions(-) > create mode 100644 grub-core/commands/pgp.c > delete mode 100644 grub-core/commands/verify.c > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index dfcc95d..3008b58 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makefile.core.def > @@ -888,8 +888,8 @@ module = { > }; > > module = { > - name = verify; > - common = commands/verify.c; > + name = pgp; > + common = commands/pgp.c; > cflags = '$(CFLAGS_POSIX)'; > cppflags = '-I$(srcdir)/lib/posix_wrap'; > }; > diff --git a/grub-core/commands/pgp.c b/grub-core/commands/pgp.c > new file mode 100644 > index 0000000..d5d7c0f > --- /dev/null > +++ b/grub-core/commands/pgp.c > @@ -0,0 +1,1018 @@ [snip] > diff --git a/grub-core/commands/verify.c b/grub-core/commands/verify.c > deleted file mode 100644 > index d5d7c0f..0000000 > --- a/grub-core/commands/verify.c > +++ /dev/null > @@ -1,1018 +0,0 @@ [snip] Scanning through this in a split view, the new file looks exactly the same as the old one. Shouldn't this just be a git mv (a rename commit) instead of deleting the old file and adding a new one?