From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
grub-devel@gnu.org, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, eric.snowberg@oracle.com,
jgross@suse.com, konrad.wilk@oracle.com, phcoder@gmail.com,
seth.goldberg@oracle.com, tsoome@me.com
Subject: Re: [MULTIBOOT2 DOC PATCH v3 01/13] multiboot2: Replace u_phys with u32
Date: Sat, 10 Dec 2016 20:23:15 +0300 [thread overview]
Message-ID: <05f42471-ac70-08a5-2599-499f54cf21a9@gmail.com> (raw)
In-Reply-To: <1481064781-16949-2-git-send-email-daniel.kiper@oracle.com>
07.12.2016 01:52, Daniel Kiper пишет:
> u_phys is used just in two places and sometimes it may confuse reader.
> Additionally, GRUB multiboot2 implementation does not use u_phys anywhere.
> So, replace it with basic well defined and used in implementation u32 type.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> doc/multiboot.texi | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> index 4b92918..2bda9b7 100644
> --- a/doc/multiboot.texi
> +++ b/doc/multiboot.texi
> @@ -299,9 +299,6 @@ little-endian, u32 is coded in little-endian.
> The type of unsigned 64-bit data. Because the target architecture is
> little-endian, u64 is coded in little-endian.
>
> -@item u_phys
> -The type of unsigned data of the same size as target architecture physical address size.
> -
> @item u_virt
> The type of unsigned data of the same size as target architecture virtual address size.
>
So if I understand it correctly, any address used in multiboot2 is
limited to 32 bit, so anything that is relevant to boot protocol must
reside below 4G. Is my assumption correct?
next prev parent reply other threads:[~2016-12-10 17:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 22:52 [MULTIBOOT2 DOC PATCH v3 00/13] multiboot2: Update documentation Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 01/13] multiboot2: Replace u_phys with u32 Daniel Kiper
2016-12-10 17:23 ` Andrei Borzenkov [this message]
2016-12-12 13:48 ` Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 02/13] multiboot2: Replace u_virt " Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 03/13] multiboot2: Rename Multiboot to Multiboot2 Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 04/13] multiboot2: Replace redundant if with the Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 05/13] multiboot2: Clarify meaning of information request header tag Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 06/13] multiboot2: Fix description of EFI boot services tag Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 07/13] multiboot2: Add description of support for EFI boot services Daniel Kiper
2016-12-07 14:33 ` Konrad Rzeszutek Wilk
2016-12-07 18:21 ` Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 08/13] multiboot2: Add description of EFI image handle tags Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 09/13] multiboot2: Add description of support for relocatable images Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 10/13] multiboot2: Say that memory maps may not be available on EFI platforms Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 11/13] multiboot2: Add C structure members alignment and padding consideration section Daniel Kiper
2016-12-06 22:53 ` [MULTIBOOT2 DOC PATCH v3 12/13] multiboot2: Add me to authors Daniel Kiper
2016-12-06 22:53 ` [MULTIBOOT2 DOC PATCH v3 13/13] multiboot2: Bump version to 2.0 Daniel Kiper
2016-12-07 3:45 ` [MULTIBOOT2 DOC PATCH v3 00/13] multiboot2: Update documentation Konrad Rzeszutek Wilk
2016-12-07 11:26 ` Daniel Kiper
2016-12-07 14:34 ` Konrad Rzeszutek Wilk
2016-12-07 18:24 ` Daniel Kiper
2016-12-09 12:57 ` Daniel Kiper
2016-12-14 13:21 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f42471-ac70-08a5-2599-499f54cf21a9@gmail.com \
--to=arvidjaar@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=eric.snowberg@oracle.com \
--cc=grub-devel@gnu.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=phcoder@gmail.com \
--cc=seth.goldberg@oracle.com \
--cc=tsoome@me.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).