From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1bSH6f-0001qR-Tx for mharc-grub-devel@gnu.org; Wed, 27 Jul 2016 01:10:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSH6d-0001nu-CJ for grub-devel@gnu.org; Wed, 27 Jul 2016 01:10:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSH6X-00066L-FY for grub-devel@gnu.org; Wed, 27 Jul 2016 01:10:06 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSH6X-00065r-83 for grub-devel@gnu.org; Wed, 27 Jul 2016 01:10:01 -0400 Received: by mail-lf0-x244.google.com with SMTP id f93so1435592lfi.0 for ; Tue, 26 Jul 2016 22:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=U/ehe0IKMiPaV4Gy4qw/RXbxo+skUOOYCW+tHuvpZqw=; b=IC23Cavi8f8YAzFje82TkZxYSm51ViI68wgxxqwARhqPyJpujPI+9gYukC1D52r5gd ppBHJlPyYX/XpU1zdocx79VyasyXQkCliZGbvIO7KsMo/vYbOsWM/cg+IxQfM1lD44Ia F7Qw81hmgpL6RjHCYJVCbm3uDtG1gYU6mSkFXBSnQ8lBKkQz9vwqh2x7PHTw9vj/kcd1 neOS2A9acIyYZAf/o5Z6sFI+l3bO9nRMWg+xqzf4wqKg5H05qv99UZ2ORMlwR5GQkxhe o7Epl8++ra0PuK6v/Et2TVddFnHsl4CDX8j+VYaiVPboc80iEkaHxNEG9FPWIZpJjLoR Y0rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=U/ehe0IKMiPaV4Gy4qw/RXbxo+skUOOYCW+tHuvpZqw=; b=bBThWtsd6zn0UBVZJaXH9/HPyaP2uclJ3GSEFf324y3ZbYMKeoDpjljx7I2QJdtRgr fsfE0I44c3En9Dfc0jn4x5HHdvECMWMWJq2XXRAyXQiuFD794vLTlZo1IR7cUX8XHhxP BieU3QwfiMJ4kqHV3pdZWqkuRM7tIDqapfYyTq/9nKbip/FiuhMQ610OEICbTtCjsYuj ddMDAxXqMGLLMivkW/vdDN2GSRL4aGoreRmuTzlUb7O3k8EJdRrjNcsFcURXfyqwfOKH k1mQJ5Z22kaC93NDdmpxN+bQQcEtYchfc4T5htH7irn7UkBsg4I05QxBJubB487IA+v3 BTLQ== X-Gm-Message-State: AEkoouu2VSZyyHHjzYRnzx6/S5ffLYUzW5bKft2AzV3P1F4z52CwaZ2G8lv+Ze/n/Npykg== X-Received: by 10.25.217.151 with SMTP id s23mr11040152lfi.16.1469596200105; Tue, 26 Jul 2016 22:10:00 -0700 (PDT) Received: from [192.168.1.44] (ppp109-252-91-231.pppoe.spdop.ru. [109.252.91.231]) by smtp.gmail.com with ESMTPSA id e22sm653033lji.1.2016.07.26.22.09.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jul 2016 22:09:59 -0700 (PDT) Subject: Re: Patch for German keyboard layout for the at_keyboard input To: The development of GNU GRUB References: <5738BDB1.2070005@posteo.org> From: Andrei Borzenkov Message-ID: <10e28a2e-0815-2a07-7eb5-3a7e0b4ea847@gmail.com> Date: Wed, 27 Jul 2016 08:09:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <5738BDB1.2070005@posteo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::244 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 05:10:08 -0000 15.05.2016 21:19, fgndevelop пишет: > > Dear team at grub-devel, > > First of all I would like to thank you for the Grand boot loader, your work is very > much appreciated. > > Recently I downloaded the current grub-2.02-beta3 and started experimenting with it. > I am am making use of the luks module in GRUB to provide my clients with fully encrypted > harddrives. Since my clients are German, and I keep telling them that strong passwords > should contain special characters, I ended up modifying the default keyboard layout > for the at_keyboard.c input driver. I provided the diff in keylayouts.c.diff, if you want > to make use of it. The support for German keys is only partial, since some of the German > keys are non-ASCII. > Layout in keylayout.c is just default one, because there should be some default. This command is used to load external layout table, so you can build German one and provide to your clients. Also GRUB is using Unicode internally, so it should be possible to use full range. See grub-mklayout.c and grub-kbdcomp. The only problem is, these utilities are too heavy Debian oriented. Making them more portable would be great. > Also I patched at_keyboard.c. It has a minor typo, in line 91 both scancode 0x52 and > 0x53 are mapped to the same GRUB_KEYBOARD_KEY_NUMDOT. This is wrong, scancode 0x52 > has to be mapped to GRUB_KEYBOARD_KEY_NUM0 (as that's what it is). > > Last but not least, parsing through include/grub/keyboard_layouts.h, I realized that the > enumeration of GRUB_KEYBOARD_KEY_* is skipping value 0x31: > > > GRUB_KEYBOARD_KEY_RBRACKET = 0x30, > > GRUB_KEYBOARD_KEY_BACKSLASH = 0x32, > > I do not know why this is the case, but from my point of view this probably lead to the > following comment ( in grub-core/commands/keylayouts.c ): > > > /* According to usage table 0x31 should be mapped to '/' > > but testing with real keyboard shows that 0x32 is remapped to '/'. > > Map 0x31 to 0. > > Cleaning up the enumeration would do some good, I guess. > > Find attached both aformentioned patches. I'll be glad help out if you deem it appropriate > to, e.g. make the support for German at_keyboard layout a configurable option. > > Regards, Frank > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >