From: "Aleš Nesrsta" <starous@volny.cz>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: [PATCH] USB serial - missing configuration
Date: Wed, 15 Sep 2010 07:58:16 +0200 [thread overview]
Message-ID: <1284530296.6578.24.camel@pracovna> (raw)
In-Reply-To: <1284401606.5929.3.camel@pracovna>
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
Hi,
I did not find configuration of USB serial device, so I made this small
patch.
Regards
Ales
[-- Attachment #2: usb_serial_100915_0 --]
[-- Type: text/x-patch, Size: 846 bytes --]
diff -urB ./kbdlayouts/grub-core/bus/usb/serial/common.c ./kbdlayouts_changed/grub-core/bus/usb/serial/common.c
--- ./kbdlayouts/grub-core/bus/usb/serial/common.c 2010-09-03 22:13:28.000000000 +0200
+++ ./kbdlayouts_changed/grub-core/bus/usb/serial/common.c 2010-09-14 17:09:30.000000000 +0200
@@ -44,6 +44,7 @@
struct grub_serial_port *port;
int j;
struct grub_usb_desc_if *interf;
+ grub_usb_err_t err = GRUB_USB_ERR_NONE;
interf = usbdev->config[configno].interf[interfno].descif;
@@ -80,7 +81,12 @@
port->out_endp = endp;
}
}
- if (!port->out_endp || !port->in_endp)
+
+ /* Configure device */
+ if (port->out_endp && port->in_endp)
+ err = grub_usb_set_configuration (usbdev, configno + 1);
+
+ if (!port->out_endp || !port->in_endp || err)
{
grub_free (port->name);
grub_free (port);
next prev parent reply other threads:[~2010-09-15 5:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 13:26 Plans on 1.99 release Vladimir 'φ-coder/phcoder' Serbinenko
2010-08-26 23:05 ` Carles Pina i Estany
2010-08-26 23:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-08-28 11:31 ` Aleš Nesrsta
2010-08-29 23:52 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-08-30 0:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-03 22:02 ` Plans on 1.99 release - USB issues Aleš Nesrsta
2010-09-04 17:34 ` Aleš Nesrsta
2010-09-12 17:28 ` [PATCH] USB issues - kbdlayouts branch Aleš Nesrsta
2010-09-13 10:43 ` [PATCH] usb_keyboard.c problems (USB issues - kbdlayouts branch) Aleš Nesrsta
2010-09-13 11:47 ` [PATCH] USB issues - kbdlayouts branch Aleš Nesrsta
2010-09-13 18:13 ` Aleš Nesrsta
2010-09-15 5:58 ` Aleš Nesrsta [this message]
2010-09-19 11:46 ` [PATCH] USB serial - missing configuration Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-21 20:18 ` Aleš Nesrsta
2010-09-23 21:13 ` Trunk: boot problem - unaligned pointer 0x Aleš Nesrsta
2010-09-26 9:58 ` Aleš Nesrsta
2010-09-30 19:37 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-30 20:45 ` Aleš Nesrsta
2010-09-15 5:58 ` Question: USB serial - device driver debugging Aleš Nesrsta
2010-09-30 17:53 ` [RFC - Vladimir ?] USB/RS232 converter PL2303 small problem Aleš Nesrsta
2010-10-17 11:54 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-09-18 10:08 ` Plans on 1.99 release - USB issues Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284530296.6578.24.camel@pracovna \
--to=starous@volny.cz \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).