[PATCH] scsi.c - cache ID bug

[PATCH] scsi.c - cache ID bug

[Aleš Nesrsta]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

Hi,

I have problem with multi-lun devices in some cases.

I found small bug in "old" problem solution of SCSI cache ID in trunk -
see attached patch which should solve it.

Regards
Ales


[-- Attachment #2: usb_scsi_cache_id_101001_0 --]
[-- Type: text/x-patch, Size: 473 bytes --]

--- ./grub/include/grub/scsi.h	2010-09-30 22:17:31.000000000 +0200
+++ ./grub_patched/include/grub/scsi.h	2010-10-01 15:58:23.000000000 +0200
@@ -40,7 +40,7 @@ static inline grub_uint32_t
 grub_make_scsi_id (int subsystem, int bus, int lun)
 {
   return (subsystem << GRUB_SCSI_ID_SUBSYSTEM_SHIFT)
-    | (bus << GRUB_SCSI_ID_BUS_SHIFT) | (lun << GRUB_SCSI_ID_BUS_SHIFT);
+    | (bus << GRUB_SCSI_ID_BUS_SHIFT) | (lun << GRUB_SCSI_ID_LUN_SHIFT);
 }
 
 struct grub_scsi_dev

Re: [PATCH] scsi.c - cache ID bug

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

On 10/01/2010 04:50 PM, Aleš Nesrsta wrote:
> Hi,
>
> I have problem with multi-lun devices in some cases.
>
> I found small bug in "old" problem solution of SCSI cache ID in trunk -
> see attached patch which should solve it.
>
>   
Go ahead
> Regards
> Ales
>
>   
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: [PATCH] scsi.c - cache ID bug

[Aleš Nesrsta]

Vladimir 'φ-coder/phcoder' Serbinenko wrote: 
> > I found small bug in "old" problem solution of SCSI cache ID in trunk -
> > see attached patch which should solve it.
> >
> >   
> Go ahead

Done, revision 2874.