From: Alexander Kurtz <kurtz.alex@googlemail.com>
To: grub-devel@gnu.org
Cc: 611123@bugs.debian.org, Colin Watson <cjwatson@debian.org>
Subject: GRUB doesn't allow background images with upper case file extensions
Date: Wed, 26 Jan 2011 11:20:26 +0100 [thread overview]
Message-ID: <1296037226.2310.2.camel@alexander> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]
Dear GRUB developers,
when I try to use background images with upper case file extensions
(e.g. `foo.JPEG') it doesn't work. If I try to debug this manually from
the grub shell, I get this:
grub> background_image /grub/comet.JPEG
error: unsupported bitmap format
grub>
This is unfortunate since most digital cameras produce images with upper
case file extensions. FAT filesystems and Windows in general might be
other sources of files with upper case file extensions.
I can confirm that the attached patch fixes the problem for me. If you
have no objections, please include it in the next version.
Best regards
Alexander Kurtz
PS: I first reported this to the Debian BTS, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611123
[-- Attachment #1.2: ignore-case-of-file-extensions.patch --]
[-- Type: text/x-patch, Size: 1048 bytes --]
diff -Naur grub2-1.99~rc1.orig/debian/changelog grub2-1.99~rc1/debian/changelog
--- grub2-1.99~rc1.orig/debian/changelog 2011-01-26 10:41:31.000000000 +0100
+++ grub2-1.99~rc1/debian/changelog 2011-01-26 10:47:06.895538285 +0100
@@ -1,3 +1,10 @@
+grub2 (1.99~rc1-1.1) experimental; urgency=low
+
+ * Non-maintainer upload
+ * Ignore case of file extensions of background images (closes: #611123).
+
+ -- Alexander Kurtz <kurtz.alex@googlemail.com> Tue, 25 Jan 2011 20:00:54 +0100
+
grub2 (1.99~rc1-1) experimental; urgency=low
[ Colin Watson ]
diff -Naur grub2-1.99~rc1.orig/grub-core/video/bitmap.c grub2-1.99~rc1/grub-core/video/bitmap.c
--- grub2-1.99~rc1.orig/grub-core/video/bitmap.c 2010-12-01 15:45:43.000000000 +0100
+++ grub2-1.99~rc1/grub-core/video/bitmap.c 2011-01-26 10:45:11.396540221 +0100
@@ -177,7 +177,7 @@
pos -= ext_len;
- return grub_strcmp (filename + pos, ext) == 0;
+ return grub_strcasecmp (filename + pos, ext) == 0;
}
/* Loads bitmap using registered bitmap readers. */
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-01-26 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 10:20 Alexander Kurtz [this message]
2011-02-02 16:31 ` GRUB doesn't allow background images with upper case file extensions Alexander Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296037226.2310.2.camel@alexander \
--to=kurtz.alex@googlemail.com \
--cc=611123@bugs.debian.org \
--cc=cjwatson@debian.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).