GRUB doesn't allow background images with upper case file extensions

GRUB doesn't allow background images with upper case file extensions

[Alexander Kurtz]

[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]

Dear GRUB developers,

when I try to use background images with upper case file extensions
(e.g. `foo.JPEG') it doesn't work. If I try to debug this manually from
the grub shell, I get this:

	grub> background_image /grub/comet.JPEG
	error: unsupported bitmap format
	grub>

This is unfortunate since most digital cameras produce images with upper
case file extensions. FAT filesystems and Windows in general might be
other sources of files with upper case file extensions.

I can confirm that the attached patch fixes the problem for me. If you
have no objections, please include it in the next version.

Best regards

Alexander Kurtz

PS: I first reported this to the Debian BTS, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611123 

[-- Attachment #1.2: ignore-case-of-file-extensions.patch --]
[-- Type: text/x-patch, Size: 1048 bytes --]

diff -Naur grub2-1.99~rc1.orig/debian/changelog grub2-1.99~rc1/debian/changelog
--- grub2-1.99~rc1.orig/debian/changelog	2011-01-26 10:41:31.000000000 +0100
+++ grub2-1.99~rc1/debian/changelog	2011-01-26 10:47:06.895538285 +0100
@@ -1,3 +1,10 @@
+grub2 (1.99~rc1-1.1) experimental; urgency=low
+
+  * Non-maintainer upload
+  * Ignore case of file extensions of background images (closes: #611123).
+  
+ -- Alexander Kurtz <kurtz.alex@googlemail.com>  Tue, 25 Jan 2011 20:00:54 +0100
+
 grub2 (1.99~rc1-1) experimental; urgency=low
 
   [ Colin Watson ]
diff -Naur grub2-1.99~rc1.orig/grub-core/video/bitmap.c grub2-1.99~rc1/grub-core/video/bitmap.c
--- grub2-1.99~rc1.orig/grub-core/video/bitmap.c	2010-12-01 15:45:43.000000000 +0100
+++ grub2-1.99~rc1/grub-core/video/bitmap.c	2011-01-26 10:45:11.396540221 +0100
@@ -177,7 +177,7 @@
 
   pos -= ext_len;
 
-  return grub_strcmp (filename + pos, ext) == 0;
+  return grub_strcasecmp (filename + pos, ext) == 0;
 }
 
 /* Loads bitmap using registered bitmap readers.  */

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: GRUB doesn't allow background images with upper case file extensions

[Alexander Kurtz]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Am Mittwoch, den 26.01.2011, 11:20 +0100 schrieb Alexander Kurtz:
> I can confirm that the attached patch fixes the problem for me. If you
> have no objections, please include it in the next version.

Ping?

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]