grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities
Date: Thu, 11 Apr 2013 20:00:34 +0400	[thread overview]
Message-ID: <13391534.dFkmsgxtKD@icedphoenix> (raw)
In-Reply-To: <3795956.oYbqbziuJu@icedphoenix>

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Oh, I think that version of patch is safer.

--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub-2.00-angle-translation.patch --]
[-- Type: text/x-patch, Size: 1441 bytes --]

diff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new/grub-core/gfxmenu/gui_circular_progress.c
--- grub-2.00/grub-core/gfxmenu/gui_circular_progress.c	2010-12-01 17:45:43.000000000 +0300
+++ grub-new/grub-core/gfxmenu/gui_circular_progress.c	2013-04-11 19:58:24.459060324 +0400
@@ -223,6 +223,34 @@
   self->end = end;
 }
 
+static int
+parse_angle (const char *value)
+{
+  int pos = 0;
+  int len = grub_strlen (value);
+  int angle = grub_strtol (value, 0, 10);
+  /* Find space symbol */
+  while (pos < len && value[pos] != ' ')
+    pos++;
+  /* Skip spaces */
+  while (pos < len && value[pos] == ' ')
+    pos++;
+  if (pos < len)
+    {
+      char *unit = grub_new_substring (value, pos, len);
+      if (!unit)
+        return angle;
+      if ((grub_strcmp (unit, "degree") == 0)
+          || (grub_strcmp (unit, "degrees") == 0))
+        angle = angle * 64 / 90;
+      else if ((grub_strcmp (unit, "rad") == 0)
+               || grub_strcmp (unit, "rads") == 0)
+        angle = angle * 64 / 100;
+      grub_free (unit);
+    }
+  return angle;
+}
+
 static grub_err_t
 circprog_set_property (void *vself, const char *name, const char *value)
 {
@@ -233,7 +261,7 @@
     }
   else if (grub_strcmp (name, "start_angle") == 0)
     {
-      self->start_angle = grub_strtol (value, 0, 10);
+      self->start_angle = parse_angle(value);
     }
   else if (grub_strcmp (name, "ticks_disappear") == 0)
     {

  parent reply	other threads:[~2013-04-11 16:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 10:52 [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities Vladimir Testov
2013-03-15 16:52 ` Andrey Borzenkov
2013-03-15 17:56   ` Lennart Sorensen
2013-03-19  7:01     ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-19  7:00   ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-19  6:57 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-04-11 15:48 ` Vladimir Testov
2013-04-11 15:56   ` Andrey Borzenkov
2013-04-11 16:00   ` Vladimir Testov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-04-12  7:27 Vladimir Testov
2013-04-19 14:16 ` Andrey Borzenkov
2013-04-23 10:22   ` Vladimir Testov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13391534.dFkmsgxtKD@icedphoenix \
    --to=vladimir.testov@rosalab.ru \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).