From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ULrPb-0006vC-Fo for mharc-grub-devel@gnu.org; Sat, 30 Mar 2013 04:45:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULrPX-0006uF-Ki for grub-devel@gnu.org; Sat, 30 Mar 2013 04:45:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULrPW-0001cv-BL for grub-devel@gnu.org; Sat, 30 Mar 2013 04:45:15 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:40795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULrPW-0001cr-3Y for grub-devel@gnu.org; Sat, 30 Mar 2013 04:45:14 -0400 Received: by mail-lb0-f173.google.com with SMTP id w20so792655lbh.4 for ; Sat, 30 Mar 2013 01:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:x-mailer; bh=wwoLMND3m3kH0b6wz/w4HD6Vk/2refJfootjprqsm/g=; b=rW3ISfSLWhQPZE9HgrLRrv4bbBOJWJRwe0gTgIcPeNzzM7cw+98fSNEraUAYjyiaa6 hGsNtVuCpYKeeyd2QIptqSTftKOg7RSVRDoZ2j5CrAllDirNnwe0vB04WZ04vlHq8tNR DGM+dPDpqpibOO08txMGR/XhJeNko5svVYIPCD846Y6GA3NwOeGOguMr4Ys33H5NJeSD Ti8miBau43VgjHq797HKKZcUxmMNl0w+NJGhYuWQ6J0weMKxanzJJBJTHoqMXyre5l3O Abwhd7glsS8oRbTbWiG6Cu5tGS53XD1Aze/wwesUskUuTncVA4D8o7dl2F3U82f5//uL FS7w== X-Received: by 10.112.24.165 with SMTP id v5mr2611107lbf.101.1364633113048; Sat, 30 Mar 2013 01:45:13 -0700 (PDT) Received: from localhost.localdomain (ppp79-139-243-180.pppoe.spdop.ru. [79.139.243.180]) by mx.google.com with ESMTPS id l1sm2289066lbn.8.2013.03.30.01.45.11 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 30 Mar 2013 01:45:12 -0700 (PDT) From: Andrey Borzenkov To: grub-devel@gnu.org Subject: [PATCH] reset LC_MESSAGES to C too Date: Sat, 30 Mar 2013 12:45:04 +0400 Message-Id: <1364633104-20097-1-git-send-email-arvidjaar@gmail.com> X-Mailer: git-send-email 1.8.1.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.173 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2013 08:45:17 -0000 If user locale has non-ASCII translation strings, running grub make outputs only question marks: bor@opensuse:~/build/grub> locale LANG=ru_RU.utf8 LC_CTYPE="ru_RU.utf8" LC_NUMERIC="ru_RU.utf8" LC_TIME="ru_RU.utf8" LC_COLLATE="ru_RU.utf8" LC_MONETARY="ru_RU.utf8" LC_MESSAGES="ru_RU.utf8" LC_PAPER="ru_RU.utf8" LC_NAME="ru_RU.utf8" LC_ADDRESS="ru_RU.utf8" LC_TELEPHONE="ru_RU.utf8" LC_MEASUREMENT="ru_RU.utf8" LC_IDENTIFICATION="ru_RU.utf8" LC_ALL= make[2]: ????? ?? ???????? `/home/bor/build/grub/docs' Making all in util/bash-completion.d make[2]: ???? ? ??????? `/home/bor/build/grub/util/bash-completion.d' make[2]: ???? `all' ?? ??????? ?????????? ??????. make[2]: ????? ?? ???????? `/home/bor/build/grub/util/bash-completion.d' make[1]: ????? ?? ???????? `/home/bor/build/grub' The reason is, grub Makefile resets LC_CTYPE to C. This makes it impossible to translate messages into current locale (C at the time tools are running). Reset LC_MESSAGES to C as well, it is better to have them in English than do not have them at all. Problem observed on Linux with glibc 2.17 and 2.15. Signed-off-by: Andrey Borzenkov --- ChangeLog | 5 +++++ conf/Makefile.common | 1 + 2 files changed, 6 insertions(+) diff --git a/ChangeLog b/ChangeLog index 58c2242..cd1f762 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-03-30 Andrey Borzenkov + + * conf/Makefile.common: Reset LC_MESSAGES to C too to avoid + question marks in messages during build on non-ASCII locale. + 2013-03-26 Vladimir Serbinenko * grub-core/kern/efi/mm.c (grub_efi_finish_boot_services): diff --git a/conf/Makefile.common b/conf/Makefile.common index c185a55..f49581d 100644 --- a/conf/Makefile.common +++ b/conf/Makefile.common @@ -4,6 +4,7 @@ CFLAGS_PLATFORM= export LC_COLLATE := C export LC_CTYPE := C +export LC_MESSAGES := C unexport LC_ALL # Platform specific options -- tg: (c643afe..) u/lc_messages (depends on: master)