From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ud1HT-0003LL-CG for mharc-grub-devel@gnu.org; Thu, 16 May 2013 12:43:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud1HR-0003LD-HY for grub-devel@gnu.org; Thu, 16 May 2013 12:43:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud1HQ-0003UZ-43 for grub-devel@gnu.org; Thu, 16 May 2013 12:43:49 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:33927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud1HP-0003U1-Sc for grub-devel@gnu.org; Thu, 16 May 2013 12:43:48 -0400 Received: by mail-lb0-f172.google.com with SMTP id y6so3366961lbh.3 for ; Thu, 16 May 2013 09:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=XKSrHleDOppHetwmV6Wk0WTCn3RjET40XS5J/CoxyBk=; b=N5XHv83+MnxLkNBVBrVh2xtVo/Y6XobSfZX3B82hmRo9VAjyQvyyRTnvYTKXNKv8AK K/vTzecYTcU/j7SUQtY0iDIOfF1ZWsA08101mopBxIzbGRvIBXXZwNumIqaKxIIv4DH2 sQbhpoe0HaxNSmxfdnIsW8zSLaDQxAsliiZjArR9oa0kPB1YIyydNAqp5C4vLowkoP4r 9SQI60rqIiJ1gQpJqTh+Y6YGReecebwvsz56AO0bO0cubbk0jYR1Ig4KO7qdRisImOGp qjjB9+DxZggSfcv3vzdaCrVFYNC5wPCBp5GkBb0weoPB1juWA1AHJx96TgBBIKCLBD6O yPaQ== X-Received: by 10.152.120.4 with SMTP id ky4mr20910190lab.5.1368722626223; Thu, 16 May 2013 09:43:46 -0700 (PDT) Received: from localhost.localdomain (ppp79-139-160-84.pppoe.spdop.ru. [79.139.160.84]) by mx.google.com with ESMTPSA id e3sm3410689lbf.17.2013.05.16.09.43.45 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 16 May 2013 09:43:45 -0700 (PDT) From: Andrey Borzenkov To: grub-devel@gnu.org Subject: [PATCH] fix listing values of variables with read hook in set command Date: Thu, 16 May 2013 20:43:37 +0400 Message-Id: <1368722617-15690-1-git-send-email-arvidjaar@gmail.com> X-Mailer: git-send-email 1.8.1.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.172 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2013 16:43:50 -0000 Variables with read hook may return valid value even before they are explicitly set. Use grub_env_get() to fetch values to ensure hooks are called. Signed-off-by: Andrey Borzenkov --- ChangeLog | 5 +++++ grub-core/kern/corecmd.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index e2e38f3..e78c9f5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-05-16 Andrey Borzenkov + + * grub-core/kern/corecmd.c (grub_core_cmd_set): Use grub_env_get + to fetch values when listing. + 2013-05-15 Radosław Szymczyszyn * grub-core/partmap/dfly.c: New partition map. diff --git a/grub-core/kern/corecmd.c b/grub-core/kern/corecmd.c index e1bb483..54ad32a 100644 --- a/grub-core/kern/corecmd.c +++ b/grub-core/kern/corecmd.c @@ -40,7 +40,7 @@ grub_core_cmd_set (struct grub_command *cmd __attribute__ ((unused)), { struct grub_env_var *env; FOR_SORTED_ENV (env) - grub_printf ("%s=%s\n", env->name, env->value); + grub_printf ("%s=%s\n", env->name, grub_env_get (env->name)); return 0; } -- tg: (0a5312f..) u/list_env (depends on: master)