grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: [PATCH] export net_* variables by default
Date: Sun, 23 Jun 2013 23:44:50 +0400	[thread overview]
Message-ID: <1372016690-24114-1-git-send-email-arvidjaar@gmail.com> (raw)

All those variables reflect physical interface properties, so they are
global by nature. Export them by default.

Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>

---
 grub-core/net/bootp.c | 6 +++++-
 grub-core/net/net.c   | 6 ++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c
index e0ab47e..72edc21 100644
--- a/grub-core/net/bootp.c
+++ b/grub-core/net/bootp.c
@@ -49,6 +49,7 @@ set_env_limn_ro (const char *intername, const char *suffix,
   grub_env_set (varname, value);
   value[len] = c;
   grub_register_variable_hook (varname, 0, grub_env_write_readonly);
+  grub_env_export (varname);
 }
 
 static void
@@ -212,7 +213,10 @@ grub_net_configure_by_dhcp_ack (const char *name,
     }
 
   if (is_def)
-    grub_env_set ("net_default_interface", name);
+    {
+      grub_env_set ("net_default_interface", name);
+      grub_env_export ("net_default_interface");
+    }
 
   if (device && !*device && bp->server_ip)
     {
diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 5d2c2f0..4810319 100644
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -891,6 +891,7 @@ grub_net_network_level_interface_register (struct grub_net_network_level_interfa
 	*ptr = '_';    
     grub_env_set (name, buf);
     grub_register_variable_hook (name, 0, hwaddr_set_env);
+    grub_env_export (name);
   }
 
   {
@@ -904,6 +905,7 @@ grub_net_network_level_interface_register (struct grub_net_network_level_interfa
 	*ptr = '_';    
     grub_env_set (name, buf);
     grub_register_variable_hook (name, 0, addr_set_env);
+    grub_env_export (name);
   }
 
   inter->card->num_ifaces++;
@@ -1643,12 +1645,16 @@ GRUB_MOD_INIT(net)
 {
   grub_register_variable_hook ("net_default_server", defserver_get_env,
 			       defserver_set_env);
+  grub_env_export ("net_default_server");
   grub_register_variable_hook ("pxe_default_server", defserver_get_env,
 			       defserver_set_env);
+  grub_env_export ("pxe_default_server");
   grub_register_variable_hook ("net_default_ip", defip_get_env,
 			       defip_set_env);
+  grub_env_export ("net_default_ip");
   grub_register_variable_hook ("net_default_mac", defmac_get_env,
 			       defmac_set_env);
+  grub_env_export ("net_default_mac");
 
   cmd_addaddr = grub_register_command ("net_add_addr", grub_cmd_addaddr,
 					/* TRANSLATORS: HWADDRESS stands for
-- 
tg: (2cca311..) u/net_var_export (depends on: master)


             reply	other threads:[~2013-06-23 19:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-23 19:44 Andrey Borzenkov [this message]
2013-07-14 11:40 ` [PATCH] export net_* variables by default Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372016690-24114-1-git-send-email-arvidjaar@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).