grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: [PATCH] restore -nostdlib for libgcc symbols tests
Date: Sat, 16 Nov 2013 08:49:44 +0400	[thread overview]
Message-ID: <1384577384-30226-1-git-send-email-arvidjaar@gmail.com> (raw)
In-Reply-To: <528632AF.8090303@gmail.com>

> -static shouldn't create problems. Adding -nostdlib like I proposed
> should solve the problem.

Right, it was fallout of "plug the leakage" patch. I think below
patch is more aligned with the rest of code.

Commit 24f4e57c4684471da088c504dec0380886eece0c plugged leakage
of CFLAGS between individual tests, which broke test for libgcc
symbols. It needs -nostdlib which was set in previous test and
inherited before. Set it explicitly.

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2c4f019..1842910 100644
--- a/configure.ac
+++ b/configure.ac
@@ -815,9 +815,9 @@ LIBS="$TARGET_LIBGCC"
 grub_ASM_USCORE
 if test "x$TARGET_APPLE_LINKER" = x0 ; then
 if test x$grub_cv_asm_uscore = xyes; then
-CFLAGS="$TARGET_CFLAGS -Wl,--defsym,_abort=_main"
+CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,_abort=_main"
 else
-CFLAGS="$TARGET_CFLAGS -Wl,--defsym,abort=main"
+CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,abort=main"
 fi
 fi
 
-- 
tg: (59ba9d1..) u/configure_nostdlib (depends on: master)


  parent reply	other threads:[~2013-11-16  4:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15  5:19 PPC build failure with undefined symbols __ashldi3, _restgpr_14_x, Andrey Borzenkov
2013-11-15 11:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-15 12:22   ` Andrey Borzenkov
2013-11-15 12:33     ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-15 13:43       ` Andrey Borzenkov
2013-11-15 14:02         ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-15 14:35           ` Andrey Borzenkov
2013-11-15 14:41             ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-15 14:53               ` Andrey Borzenkov
2013-11-16  4:49               ` Andrey Borzenkov [this message]
2013-11-16 12:51                 ` [PATCH] restore -nostdlib for libgcc symbols tests Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384577384-30226-1-git-send-email-arvidjaar@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).