From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VhXpa-0005MZ-OE for mharc-grub-devel@gnu.org; Fri, 15 Nov 2013 23:50:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54390) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhXpT-0005ML-La for grub-devel@gnu.org; Fri, 15 Nov 2013 23:50:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhXpO-0003av-3A for grub-devel@gnu.org; Fri, 15 Nov 2013 23:49:55 -0500 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:51348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhXpN-0003ar-Qp for grub-devel@gnu.org; Fri, 15 Nov 2013 23:49:50 -0500 Received: by mail-la0-f49.google.com with SMTP id er20so3322126lab.8 for ; Fri, 15 Nov 2013 20:49:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=b1olp3S6bSsbagA0CEmwGimx3Nq0P9SiRZjqnXJTN7I=; b=EQScxGe1Zyrj1+sppUjGfkKZ9YXsuR74Vssqi4xgOSEHGqOvMSKUd56TPyMNhW6oFN wpIRRmkoW/N6z6rxmEOI7a5o4Pz6gnE1OWOLh40BPBEUxzhD9+5pYy4fOO8gGIP7QrDu z5uiP2+AxH9tIE4q60kjUS62M75iA1C3hzN7HcEGjcwqAOq0vo8dzEmCe/t9/DXxfEJN 0VMipLc6hgulUJlczsYHu+YL0e5eWo3uyneizzPBLVRXgZp52Wj4Z8EsVzFkSTinhq8V KIONMzRZcezjubouogJeuzJaN32h9hRCn7PBgH6Ak4ywbn5ry7+YASZOTn1FitVZCatO ssTw== X-Received: by 10.112.51.101 with SMTP id j5mr5495557lbo.17.1384577388492; Fri, 15 Nov 2013 20:49:48 -0800 (PST) Received: from localhost.localdomain (ppp91-76-174-89.pppoe.mtu-net.ru. [91.76.174.89]) by mx.google.com with ESMTPSA id pg3sm4333832lbb.7.2013.11.15.20.49.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Nov 2013 20:49:48 -0800 (PST) From: Andrey Borzenkov To: grub-devel@gnu.org Subject: [PATCH] restore -nostdlib for libgcc symbols tests Date: Sat, 16 Nov 2013 08:49:44 +0400 Message-Id: <1384577384-30226-1-git-send-email-arvidjaar@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <528632AF.8090303@gmail.com> References: <528632AF.8090303@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Nov 2013 04:50:01 -0000 > -static shouldn't create problems. Adding -nostdlib like I proposed > should solve the problem. Right, it was fallout of "plug the leakage" patch. I think below patch is more aligned with the rest of code. Commit 24f4e57c4684471da088c504dec0380886eece0c plugged leakage of CFLAGS between individual tests, which broke test for libgcc symbols. It needs -nostdlib which was set in previous test and inherited before. Set it explicitly. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 2c4f019..1842910 100644 --- a/configure.ac +++ b/configure.ac @@ -815,9 +815,9 @@ LIBS="$TARGET_LIBGCC" grub_ASM_USCORE if test "x$TARGET_APPLE_LINKER" = x0 ; then if test x$grub_cv_asm_uscore = xyes; then -CFLAGS="$TARGET_CFLAGS -Wl,--defsym,_abort=_main" +CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,_abort=_main" else -CFLAGS="$TARGET_CFLAGS -Wl,--defsym,abort=main" +CFLAGS="$TARGET_CFLAGS -nostdlib -Wl,--defsym,abort=main" fi fi -- tg: (59ba9d1..) u/configure_nostdlib (depends on: master)