grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Jon McCune <jonmccune@google.com>
To: grub-devel@gnu.org
Cc: Jon McCune <jonmccune@google.com>
Subject: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported.
Date: Mon,  2 Dec 2013 11:13:15 -0800	[thread overview]
Message-ID: <1386011595-14832-1-git-send-email-jonmccune@google.com> (raw)

A reasonable alternative would be to completely remove all traces
of --grub-mkimage, and simply have it fail like any other unrecognized
flag to grub-install, but this will not be as clear to those who may
go looking for what has happened to --grub-mkimage.

Signed-off-by: Jon McCune <jonmccune@google.com>
---
 util/grub-install-common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/grub-install-common.c b/util/grub-install-common.c
index 03c6f13..fcb4d66 100644
--- a/util/grub-install-common.c
+++ b/util/grub-install-common.c
@@ -359,7 +359,8 @@ grub_install_parse (int key, char *arg)
 	}
       grub_util_error (_("Unrecognized compression `%s'"), arg);
     case GRUB_INSTALL_OPTIONS_GRUB_MKIMAGE:
-      return 1;
+      grub_util_error (_("Option --grub-mkimage is no longer supported"));
+      return 0;
     default:
       return 0;
     }
-- 
1.8.4.1



             reply	other threads:[~2013-12-02 19:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 19:13 Jon McCune [this message]
2013-12-02 19:20 ` [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 19:29   ` Jonathan McCune

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386011595-14832-1-git-send-email-jonmccune@google.com \
    --to=jonmccune@google.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).