From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VnYvv-0001Fn-2s for mharc-grub-devel@gnu.org; Mon, 02 Dec 2013 14:13:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnYvr-0001Aa-5l for grub-devel@gnu.org; Mon, 02 Dec 2013 14:13:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnYvo-0000vM-DV for grub-devel@gnu.org; Mon, 02 Dec 2013 14:13:23 -0500 Received: from mail-ob0-x249.google.com ([2607:f8b0:4003:c01::249]:50132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnYvo-0000uT-9F for grub-devel@gnu.org; Mon, 02 Dec 2013 14:13:20 -0500 Received: by mail-ob0-f201.google.com with SMTP id va2so2588848obc.2 for ; Mon, 02 Dec 2013 11:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=j0lgkxpd1z56e9Qo1gQYMDBwjjvlCRIuu8FmqHAY8G4=; b=PIc3ZNMCSzB/xU66za8W92TayKoKEWvLGyATgGFfvIlkR+eW2c6bCS2V2TvPdgvJBq UmcfkF09szlESA/af9wAwRPkKIacgYnxQfr2ELOqmnVhXOEEX00VacGH413NzeULD1Ef 4iRejWn5c+LyBmXCqdDwbotS2WIih7qnr2BADHHHHw3MnSGA1+GyJWl9Sa1NmLxI/l1i cMMiMYZiMd+4auLhLbo0lJU+J8Hx9hxfgiT7kWammU2HiA4pS7bcMOJpNNiJHq2kd5S7 2eHMTTzHAj8uMBDSwPzlX7INU0bGscBugjhdnQJ8SxtQdrP4QfacGcUBdch9RyEl1QB1 DQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j0lgkxpd1z56e9Qo1gQYMDBwjjvlCRIuu8FmqHAY8G4=; b=beogxMdxl9L8xo9svvtKgA8NZGFygkk0D8Wi7v8xNsJvqe0l0y6Hf6Wazd5NaJ7wWh kQULp+T3vI0esia0QBoheqMvtw8bvnUJjzadsGjUbInspU4ziQeAq86MSgORaSIS1lDY USeW8DaW2p71069mS/600VHjyysqZE9d2kRBtBxj0iORu/+faThl1WMRxRxM8G9AeS1Z RwHFJzZgoJp9gp6bgr68CyS2Oswd5m1mqM7Iy/rI6JVCEi9SAN1JrWXC9wYo0vSndiqr jybETNaZZntIpvesneOJp2JVbKB0ok1DoT/wqFiPXJyE0tKC1lg686TQFO+BEOQKaG7Q 9Ikg== X-Gm-Message-State: ALoCoQl9ZBRNZIYEu6y4dD9DuR+AlD0j9TD7gDQorhPhftTD3eiI4OEychwqE/ep66YfpG4gTY8aSPbCYaBY27r6SKejyg4teN3lah60h7+Y6qh0CEWoRSh2J6koDFI0jwCFgVUhl0xe1gsAxJMim0D5b6jNujOn4me0DW/vYUBdQVADtHQHl/5qjB7/lRitIXZ/EETPiWbsFhMefPItCNOVJWQzaGOnbv/h8BJLdmKOVoEYpw/yqyk= X-Received: by 10.42.84.136 with SMTP id m8mr20451112icl.9.1386011599695; Mon, 02 Dec 2013 11:13:19 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id d9si16767395yhl.2.2013.12.02.11.13.19 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Dec 2013 11:13:19 -0800 (PST) Received: from yinz.mtv.corp.google.com (yinz.mtv.corp.google.com [172.17.81.122]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 86B575A409A; Mon, 2 Dec 2013 11:13:19 -0800 (PST) Received: by yinz.mtv.corp.google.com (Postfix, from userid 184367) id 2ED92C05BC; Mon, 2 Dec 2013 11:13:19 -0800 (PST) From: Jon McCune To: grub-devel@gnu.org Subject: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported. Date: Mon, 2 Dec 2013 11:13:15 -0800 Message-Id: <1386011595-14832-1-git-send-email-jonmccune@google.com> X-Mailer: git-send-email 1.8.4.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::249 Cc: Jon McCune X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 19:13:25 -0000 A reasonable alternative would be to completely remove all traces of --grub-mkimage, and simply have it fail like any other unrecognized flag to grub-install, but this will not be as clear to those who may go looking for what has happened to --grub-mkimage. Signed-off-by: Jon McCune --- util/grub-install-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/grub-install-common.c b/util/grub-install-common.c index 03c6f13..fcb4d66 100644 --- a/util/grub-install-common.c +++ b/util/grub-install-common.c @@ -359,7 +359,8 @@ grub_install_parse (int key, char *arg) } grub_util_error (_("Unrecognized compression `%s'"), arg); case GRUB_INSTALL_OPTIONS_GRUB_MKIMAGE: - return 1; + grub_util_error (_("Option --grub-mkimage is no longer supported")); + return 0; default: return 0; } -- 1.8.4.1