From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)
Date: Fri, 27 Dec 2013 22:25:17 +0400 [thread overview]
Message-ID: <1388168717.918.74.camel@opensuse.site> (raw)
In-Reply-To: <1388087687.918.69.camel@opensuse.site>
В Чт, 26/12/2013 в 23:54 +0400, Andrey Borzenkov пишет:
> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
> build-grub-pe2elf. Those are build time programs and so use
> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
> compiles just fine with error.h commented out. May be something like
>
> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)
>
On the second glance - why is <error.h> needed at all? Nothing defined
there is used in misc.c and on Linux it compiles just fine with error.h
as well.
May be we could simply drop it?
next prev parent reply other threads:[~2013-12-27 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 19:54 error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile) Andrey Borzenkov
2013-12-27 18:25 ` Andrey Borzenkov [this message]
2013-12-27 19:34 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-28 5:11 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388168717.918.74.camel@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).