error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)

error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)

[Andrey Borzenkov]

I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
build-grub-pe2elf. Those are build time programs and so use
BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
compiles just fine with error.h commented out. May be something like

#if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)

Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)

[Andrey Borzenkov]

В Чт, 26/12/2013 в 23:54 +0400, Andrey Borzenkov пишет:
> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
> build-grub-pe2elf. Those are build time programs and so use
> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
> compiles just fine with error.h commented out. May be something like
> 
> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)
> 

On the second glance - why is <error.h> needed at all? Nothing defined
there is used in misc.c and on Linux it compiles just fine with error.h
as well.

May be we could simply drop it?

Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On 27.12.2013 19:25, Andrey Borzenkov wrote:
> В Чт, 26/12/2013 в 23:54 +0400, Andrey Borzenkov пишет:
>> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
>> build-grub-pe2elf. Those are build time programs and so use
>> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
>> compiles just fine with error.h commented out. May be something like
>>
>> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)
>>
> 
> On the second glance - why is <error.h> needed at all? Nothing defined
> there is used in misc.c and on Linux it compiles just fine with error.h
> as well.
> 
> May be we could simply drop it?
> 
Yes. I was going to answer with this. Many of includes are inherited by
copying of include parts.
error.h there can simply be removed
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]

Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile)

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

В Пт, 27/12/2013 в 20:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
пишет:
> On 27.12.2013 19:25, Andrey Borzenkov wrote:
> > В Чт, 26/12/2013 в 23:54 +0400, Andrey Borzenkov пишет:
> >> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and
> >> build-grub-pe2elf. Those are build time programs and so use
> >> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It
> >> compiles just fine with error.h commented out. May be something like
> >>
> >> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H)
> >>
> > 
> > On the second glance - why is <error.h> needed at all? Nothing defined
> > there is used in misc.c and on Linux it compiles just fine with error.h
> > as well.
> > 
> > May be we could simply drop it?
> > 
> Yes. I was going to answer with this. Many of includes are inherited by
> copying of include parts.
> error.h there can simply be removed

done

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]