grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: cmosclean command name
Date: Sat, 28 Dec 2013 09:18:47 +0400	[thread overview]
Message-ID: <1388207927.918.86.camel@opensuse.site> (raw)
In-Reply-To: <20131228023147.GA5371@riva.ucam.org>

В Сб, 28/12/2013 в 02:31 +0000, Colin Watson пишет:
> On Fri, Dec 27, 2013 at 08:04:09AM +0400, Andrey Borzenkov wrote:
> > В Пт, 27/12/2013 в 02:22 +0000, Colin Watson пишет:
> > > While writing up NEWS entries for 2.02, I noticed a slight irregularity
> > > in grub-core/commands/i386/cmostest.c: the "cmosclean" command is
> > > described as "Clear bit at BYTE:BIT in CMOS.".  Wouldn't the command be
> > > better named "cmosclear" rather than "cmosclean"?  "Clean" is an odd
> > > verb to use for this in English.
> > 
> > Sounds fine and is better counterpart to"cmosset".
> 
> I realised that I was wrong that it was introduced in 2.02, though; it
> was in fact new in 1.99, so it needs more of an effort at compatibility.
> What do people think of this?
> 

> 	* Rename "cmosclean" command to "cmosclear", leaving an alias for
> 	  compatibility.  Similarly, rename "GRUB_BUTTON_CMOS_CLEAN" to
> 	  "GRUB_BUTTON_CMOS_CLEAR" and leave an alias.
> 

Good occasion to also add description of "GRUB_BUTTON_CMOS_CLEAR" to
documentation :)



      reply	other threads:[~2013-12-28  5:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27  2:22 cmosclean command name Colin Watson
2013-12-27  4:04 ` Andrey Borzenkov
2013-12-28  2:31   ` Colin Watson
2013-12-28  5:18     ` Andrey Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1388207927.918.86.camel@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).