From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 6/7] mkimage: support images which require full relocation at mkimage time.
Date: Mon, 30 Dec 2013 19:46:43 +0400 [thread overview]
Message-ID: <1388418403.918.129.camel@opensuse.site> (raw)
In-Reply-To: <1388342856-18317-6-git-send-email-ijc@hellion.org.uk>
В Вс, 29/12/2013 в 18:47 +0000, Ian Campbell пишет:
> @@ -1530,9 +1551,9 @@ SUFFIX (load_image) (const char *kernel_path, size_t *exec_size,
> for (i = 0; i < num_sections; i++)
> section_vaddresses[i] = section_addresses[i] + image_target->vaddr_offset;
>
> - if (!grub_image_needs_reloc(image_target))
> + if (!grub_image_needs_reloc(image_target) || grub_image_needs_abs_reloc(image_target))
> {
grub_image_needs_reloc implies grub_image_need_abs_reloc. Looks like one
of hunks should be dropped?
> @@ -922,11 +923,16 @@ grub_arm_reloc_jump24 (grub_uint32_t *target, Elf32_Addr sym_addr)
> static int grub_image_needs_reloc(const struct grub_install_image_target_desc *target)
> {
> if (target->id == IMAGE_EFI)
> return 1;
> - return 0;
> + return grub_image_needs_abs_reloc(target);
> }
>
next prev parent reply other threads:[~2013-12-30 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 18:47 [PATCH 0/7] arm-uboot: support for different RAM bases Ian Campbell
2013-12-29 18:47 ` [PATCH 1/7] mkimage: Refactor IMAGE_EFI checks into a function grub_image_needs_reloc Ian Campbell
2013-12-29 18:47 ` [PATCH 2/7] mkimage: Replace hardcoded 0x400 in R_ARM_ABS32 relocation Ian Campbell
2013-12-29 18:47 ` [PATCH 3/7] mkimage: account for space for trampolines earlier Ian Campbell
2013-12-29 18:47 ` [PATCH 4/7] mkimage: make R_ARM_ABS32 debug output more consistent Ian Campbell
2013-12-29 18:47 ` [PATCH 5/7] mkimage: allow linking at address 0 Ian Campbell
2013-12-29 18:47 ` [PATCH 6/7] mkimage: support images which require full relocation at mkimage time Ian Campbell
2013-12-29 22:53 ` Leif Lindholm
2013-12-30 3:49 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-30 10:54 ` Ian Campbell
2013-12-30 15:46 ` Andrey Borzenkov [this message]
2013-12-31 14:19 ` Francesco Lavra
2013-12-31 16:44 ` Ian Campbell
2013-12-29 18:47 ` [PATCH 7/7] arm-uboot: support relocation at installation time Ian Campbell
2013-12-29 19:10 ` [PATCH 0/7] arm-uboot: support for different RAM bases Ian Campbell
2013-12-29 23:04 ` Leif Lindholm
2013-12-30 1:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-30 10:48 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388418403.918.129.camel@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).