grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fix name of default boot image on AArch64
Date: Mon, 06 Jan 2014 20:29:31 +0400	[thread overview]
Message-ID: <1389025771.918.202.camel@opensuse.site> (raw)
In-Reply-To: <20140106113425.GG29433@bivouac.eciton.net>

В Пн, 06/01/2014 в 11:34 +0000, Leif Lindholm пишет:
> On Wed, Jan 01, 2014 at 12:54:36PM +0400, Andrey Borzenkov wrote:
> > According to UEFI 2.4 specification, default boot file name on AArch64
> > is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
> > 
> > ---
> >  util/grub-install.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/util/grub-install.c b/util/grub-install.c
> > index 8cfe0ea..d3b9db7 100644
> > --- a/util/grub-install.c
> > +++ b/util/grub-install.c
> > @@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
> >  	      efi_file = "BOOTARM.EFI";
> >  	      break;
> >  	    case GRUB_INSTALL_PLATFORM_ARM64_EFI:
> > -	      efi_file = "BOOTAARCH64.EFI";
> > +	      efi_file = "BOOTAA64.EFI";
> >  	      break;
> >  	    default:
> >  	      grub_util_error ("%s", _("You've found a bug"));
> > -- 
> > tg: (668add2..) u/aarch64-default-boot (depends on: master)
> 
> Oops - muscle memory override.
> My only excuse is that current Tianocore Bds for arm* is not conformant
> to the removable media boot behaviour, so this could not currently be
> tested. Fixing this is on my to-do list for Q1.
> Could this be applied please?
> 

Should not grubarm64 be changed into grubaa64 as well, even to just fit
into 8+3 name? Having them consistent makes life easier. And now is just
the right point in time before name is set in stone.



  reply	other threads:[~2014-01-06 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-01  8:54 [PATCH] fix name of default boot image on AArch64 Andrey Borzenkov
2014-01-06 11:34 ` Leif Lindholm
2014-01-06 16:29   ` Andrey Borzenkov [this message]
2014-01-06 16:51     ` Leif Lindholm
2014-01-06 17:51     ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-07  6:39       ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389025771.918.202.camel@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).