* [PATCH] fix name of default boot image on AArch64
@ 2014-01-01 8:54 Andrey Borzenkov
2014-01-06 11:34 ` Leif Lindholm
0 siblings, 1 reply; 6+ messages in thread
From: Andrey Borzenkov @ 2014-01-01 8:54 UTC (permalink / raw)
To: grub-devel
According to UEFI 2.4 specification, default boot file name on AArch64
is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
---
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index 8cfe0ea..d3b9db7 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
efi_file = "BOOTARM.EFI";
break;
case GRUB_INSTALL_PLATFORM_ARM64_EFI:
- efi_file = "BOOTAARCH64.EFI";
+ efi_file = "BOOTAA64.EFI";
break;
default:
grub_util_error ("%s", _("You've found a bug"));
--
tg: (668add2..) u/aarch64-default-boot (depends on: master)
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] fix name of default boot image on AArch64
2014-01-01 8:54 [PATCH] fix name of default boot image on AArch64 Andrey Borzenkov
@ 2014-01-06 11:34 ` Leif Lindholm
2014-01-06 16:29 ` Andrey Borzenkov
0 siblings, 1 reply; 6+ messages in thread
From: Leif Lindholm @ 2014-01-06 11:34 UTC (permalink / raw)
To: The development of GNU GRUB
On Wed, Jan 01, 2014 at 12:54:36PM +0400, Andrey Borzenkov wrote:
> According to UEFI 2.4 specification, default boot file name on AArch64
> is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
>
> ---
> util/grub-install.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/grub-install.c b/util/grub-install.c
> index 8cfe0ea..d3b9db7 100644
> --- a/util/grub-install.c
> +++ b/util/grub-install.c
> @@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
> efi_file = "BOOTARM.EFI";
> break;
> case GRUB_INSTALL_PLATFORM_ARM64_EFI:
> - efi_file = "BOOTAARCH64.EFI";
> + efi_file = "BOOTAA64.EFI";
> break;
> default:
> grub_util_error ("%s", _("You've found a bug"));
> --
> tg: (668add2..) u/aarch64-default-boot (depends on: master)
Oops - muscle memory override.
My only excuse is that current Tianocore Bds for arm* is not conformant
to the removable media boot behaviour, so this could not currently be
tested. Fixing this is on my to-do list for Q1.
Could this be applied please?
/
Leif
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix name of default boot image on AArch64
2014-01-06 11:34 ` Leif Lindholm
@ 2014-01-06 16:29 ` Andrey Borzenkov
2014-01-06 16:51 ` Leif Lindholm
2014-01-06 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 2 replies; 6+ messages in thread
From: Andrey Borzenkov @ 2014-01-06 16:29 UTC (permalink / raw)
To: grub-devel
В Пн, 06/01/2014 в 11:34 +0000, Leif Lindholm пишет:
> On Wed, Jan 01, 2014 at 12:54:36PM +0400, Andrey Borzenkov wrote:
> > According to UEFI 2.4 specification, default boot file name on AArch64
> > is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
> >
> > ---
> > util/grub-install.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/util/grub-install.c b/util/grub-install.c
> > index 8cfe0ea..d3b9db7 100644
> > --- a/util/grub-install.c
> > +++ b/util/grub-install.c
> > @@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
> > efi_file = "BOOTARM.EFI";
> > break;
> > case GRUB_INSTALL_PLATFORM_ARM64_EFI:
> > - efi_file = "BOOTAARCH64.EFI";
> > + efi_file = "BOOTAA64.EFI";
> > break;
> > default:
> > grub_util_error ("%s", _("You've found a bug"));
> > --
> > tg: (668add2..) u/aarch64-default-boot (depends on: master)
>
> Oops - muscle memory override.
> My only excuse is that current Tianocore Bds for arm* is not conformant
> to the removable media boot behaviour, so this could not currently be
> tested. Fixing this is on my to-do list for Q1.
> Could this be applied please?
>
Should not grubarm64 be changed into grubaa64 as well, even to just fit
into 8+3 name? Having them consistent makes life easier. And now is just
the right point in time before name is set in stone.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix name of default boot image on AArch64
2014-01-06 16:29 ` Andrey Borzenkov
@ 2014-01-06 16:51 ` Leif Lindholm
2014-01-06 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
1 sibling, 0 replies; 6+ messages in thread
From: Leif Lindholm @ 2014-01-06 16:51 UTC (permalink / raw)
To: The development of GNU GRUB
On Mon, Jan 06, 2014 at 08:29:31PM +0400, Andrey Borzenkov wrote:
> > > case GRUB_INSTALL_PLATFORM_ARM64_EFI:
> > > - efi_file = "BOOTAARCH64.EFI";
> > > + efi_file = "BOOTAA64.EFI";
> > > break;
> > > default:
> > > grub_util_error ("%s", _("You've found a bug"));
> > > --
> > > tg: (668add2..) u/aarch64-default-boot (depends on: master)
> >
> > Oops - muscle memory override.
> > My only excuse is that current Tianocore Bds for arm* is not conformant
> > to the removable media boot behaviour, so this could not currently be
> > tested. Fixing this is on my to-do list for Q1.
> > Could this be applied please?
>
> Should not grubarm64 be changed into grubaa64 as well, even to just fit
> into 8+3 name? Having them consistent makes life easier. And now is just
> the right point in time before name is set in stone.
It would be more consistent, and if the intent is to match the
removable media loader filename, the correct thing to do.
/
Leif
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix name of default boot image on AArch64
2014-01-06 16:29 ` Andrey Borzenkov
2014-01-06 16:51 ` Leif Lindholm
@ 2014-01-06 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-07 6:39 ` Andrey Borzenkov
1 sibling, 1 reply; 6+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2014-01-06 17:51 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]
On 06.01.2014 17:29, Andrey Borzenkov wrote:
> В Пн, 06/01/2014 в 11:34 +0000, Leif Lindholm пишет:
>> On Wed, Jan 01, 2014 at 12:54:36PM +0400, Andrey Borzenkov wrote:
>>> According to UEFI 2.4 specification, default boot file name on AArch64
>>> is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
>>>
>>> ---
>>> util/grub-install.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/util/grub-install.c b/util/grub-install.c
>>> index 8cfe0ea..d3b9db7 100644
>>> --- a/util/grub-install.c
>>> +++ b/util/grub-install.c
>>> @@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
>>> efi_file = "BOOTARM.EFI";
>>> break;
>>> case GRUB_INSTALL_PLATFORM_ARM64_EFI:
>>> - efi_file = "BOOTAARCH64.EFI";
>>> + efi_file = "BOOTAA64.EFI";
>>> break;
>>> default:
>>> grub_util_error ("%s", _("You've found a bug"));
>>> --
>>> tg: (668add2..) u/aarch64-default-boot (depends on: master)
>>
>> Oops - muscle memory override.
>> My only excuse is that current Tianocore Bds for arm* is not conformant
>> to the removable media boot behaviour, so this could not currently be
>> tested. Fixing this is on my to-do list for Q1.
>> Could this be applied please?
>>
>
> Should not grubarm64 be changed into grubaa64 as well, even to just fit
> into 8+3 name? Having them consistent makes life easier. And now is just
> the right point in time before name is set in stone.
>
Agreed. Could you do it?
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fix name of default boot image on AArch64
2014-01-06 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2014-01-07 6:39 ` Andrey Borzenkov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Borzenkov @ 2014-01-07 6:39 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]
В Пн, 06/01/2014 в 18:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
пишет:
> On 06.01.2014 17:29, Andrey Borzenkov wrote:
> > В Пн, 06/01/2014 в 11:34 +0000, Leif Lindholm пишет:
> >> On Wed, Jan 01, 2014 at 12:54:36PM +0400, Andrey Borzenkov wrote:
> >>> According to UEFI 2.4 specification, default boot file name on AArch64
> >>> is BOOTAA64.EFI (3.4.1.1 Removable Media Boot Behavior).
> >>>
> >>> ---
> >>> util/grub-install.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/util/grub-install.c b/util/grub-install.c
> >>> index 8cfe0ea..d3b9db7 100644
> >>> --- a/util/grub-install.c
> >>> +++ b/util/grub-install.c
> >>> @@ -1091,7 +1091,7 @@ main (int argc, char *argv[])
> >>> efi_file = "BOOTARM.EFI";
> >>> break;
> >>> case GRUB_INSTALL_PLATFORM_ARM64_EFI:
> >>> - efi_file = "BOOTAARCH64.EFI";
> >>> + efi_file = "BOOTAA64.EFI";
> >>> break;
> >>> default:
> >>> grub_util_error ("%s", _("You've found a bug"));
> >>> --
> >>> tg: (668add2..) u/aarch64-default-boot (depends on: master)
> >>
> >> Oops - muscle memory override.
> >> My only excuse is that current Tianocore Bds for arm* is not conformant
> >> to the removable media boot behaviour, so this could not currently be
> >> tested. Fixing this is on my to-do list for Q1.
> >> Could this be applied please?
> >>
> >
> > Should not grubarm64 be changed into grubaa64 as well, even to just fit
> > into 8+3 name? Having them consistent makes life easier. And now is just
> > the right point in time before name is set in stone.
> >
> Agreed. Could you do it?
Done.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-07 6:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-01 8:54 [PATCH] fix name of default boot image on AArch64 Andrey Borzenkov
2014-01-06 11:34 ` Leif Lindholm
2014-01-06 16:29 ` Andrey Borzenkov
2014-01-06 16:51 ` Leif Lindholm
2014-01-06 17:51 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-07 6:39 ` Andrey Borzenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).