* [PATCH] fix crash in CLI on empty line with continuation
@ 2014-01-25 21:41 Andrey Borzenkov
0 siblings, 0 replies; only message in thread
From: Andrey Borzenkov @ 2014-01-25 21:41 UTC (permalink / raw)
To: grub-devel
GRUB would crash when getting the following (without quotes)
"\RETURN
"RETURN
This results in empty args. OTOH having empty first argument is not really
a problem (it simply fails to find empty command name).
---
grub-core/script/execute.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/script/execute.c b/grub-core/script/execute.c
index afd5513..6ef12a0 100644
--- a/grub-core/script/execute.c
+++ b/grub-core/script/execute.c
@@ -920,7 +920,7 @@ grub_script_execute_cmdline (struct grub_script_cmd *cmd)
struct grub_script_argv argv = { 0, 0, 0 };
/* Lookup the command. */
- if (grub_script_arglist_to_argv (cmdline->arglist, &argv) || ! argv.args[0])
+ if (grub_script_arglist_to_argv (cmdline->arglist, &argv) || ! argv.args)
return grub_errno;
invert = 0;
--
tg: (5ae584c..) u/zero_args_crash (depends on: master)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-01-25 21:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-25 21:41 [PATCH] fix crash in CLI on empty line with continuation Andrey Borzenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).