grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Piotr Krysiuk <piotras@gmail.com>
To: grub-devel@gnu.org
Cc: Piotr Krysiuk <piotras@gmail.com>
Subject: [PATCHv2] Unable to boot very old Linux kernels
Date: Tue, 15 Apr 2014 12:58:40 +0100	[thread overview]
Message-ID: <1397563120-3509-1-git-send-email-piotras@gmail.com> (raw)

GRUB cannot determine end of BSS section of compressed image when loading
very old Linux kernels.  Booting these kernels, grub_relocator32_start and
new Global Descriptor Table are placed in the area overlapping with the BSS
section of loaded image.  When Linux executes, it initializes BSS also
wiping Global Descriptor Table that is still active.  This leads to failure
on segment reload that follows.

Current HEAD of GRUB repository is affected, with "Clear BSS" code from
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/arch/x86_64/boot/compressed/head.S?h=linux-2.6.17.y#n57
wiping GDT.

Old versions of GRUB, from before relocator was introduced, placed GDT close
to end of physical memory avoiding this issue.  This patch fixes regression
by moving GDT into conventional memory.

	* grub-core/lib/i386/relocator.c: Move GDT into conventional memory
	to avoid collision with BSS section of compressed Linux image for
	very old kernels.
---
 grub-core/lib/i386/relocator.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/grub-core/lib/i386/relocator.c b/grub-core/lib/i386/relocator.c
index d2a1b27..ffaf25f 100644
--- a/grub-core/lib/i386/relocator.c
+++ b/grub-core/lib/i386/relocator.c
@@ -81,10 +81,13 @@ grub_relocator32_boot (struct grub_relocator *rel,
   void *relst;
   grub_relocator_chunk_t ch;
 
-  err = grub_relocator_alloc_chunk_align (rel, &ch, 0,
-					  (0xffffffff - RELOCATOR_SIZEOF (32))
-					  + 1, RELOCATOR_SIZEOF (32), 16,
-					  GRUB_RELOCATOR_PREFERENCE_NONE,
+  /* Specific memory range due to Global Descriptor Table for use by payload
+     that we will store in returned chunk.  The address range and preference
+     are based on "THE LINUX/x86 BOOT PROTOCOL" specification.  */
+  err = grub_relocator_alloc_chunk_align (rel, &ch, 0x1000,
+					  0x9a000 - RELOCATOR_SIZEOF (32),
+					  RELOCATOR_SIZEOF (32), 16,
+					  GRUB_RELOCATOR_PREFERENCE_LOW,
 					  avoid_efi_bootservices);
   if (err)
     return err;
-- 
1.7.9.5



             reply	other threads:[~2014-04-15 11:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 11:58 Piotr Krysiuk [this message]
2014-04-20 13:59 ` [PATCHv2] Unable to boot very old Linux kernels Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397563120-3509-1-git-send-email-piotras@gmail.com \
    --to=piotras@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).