grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Subject: Re: grub-shell: Pass -no-pad to xorriso when building floppy images
Date: Thu, 16 Jan 2014 19:56:16 +0100	[thread overview]
Message-ID: <1413645726316204936@scdbackup.webframe.org> (raw)
In-Reply-To: <280626457381791014728@scdbackup.webframe.org>

Hi,

> There is no second "--". grub-mkrescue --help tries to say, that
> everything after "--" is simply passed on to xorriso. What is
> confusing, is "or any of the mkisofs options" in previous sentence
> which implies that "--" is not needed.

It used to work the way which is still in the docs.

See
  http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.in?id=2.00

Its arguments are interpreted by

  while test $# -gt 0
  do
     ...
     case "$option" in
     ...
     *)
	  source="${source} ${option} $@"; break ;;
     esac
  done

I.e the unrecognized arguments are added to the list of
source files which is later submitted to the xorriso -as mkisofs
emulation:

  # build iso image
  "${xorriso}" -as mkisofs ... ${source}

Among the xorriso arguments, the "--" has the effect that xorriso
will leave mkisofs emulation and interpret the following arguments
as its native commands and their parameters.


But the new C code obviously thinks too much when seeing
single-dash arguments, which it should handle as xorriso arguments.
And it eats "--". At least if it is the first non-mkrescue argument.


So:

What argument interpretation behavior is grub-mkrescue 2.02
supposed to show ?

The one that is currently documented and matches grub-mkrescue.in 
of 2.00 ?

Or the one that is result of using grub-core/gnulib/argp-parse.c ?
The latter would need to be explored and documented, then.


Have a nice day :)

Thomas



  parent reply	other threads:[~2014-01-16 18:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 12:49 [PATCH] grub-shell: Pass -no-pad to xorriso when building floppy images Colin Watson
2014-01-16 14:05 ` Thomas Schmitt
2014-01-16 14:53   ` Colin Watson
2014-01-16 16:17     ` Thomas Schmitt
2014-01-16 16:28       ` Thomas Schmitt
2014-01-16 18:21         ` Andrey Borzenkov
2014-01-16 18:56       ` Thomas Schmitt [this message]
2014-01-16 19:13         ` Andrey Borzenkov
2014-01-16 19:43           ` Thomas Schmitt
2014-01-22 15:12     ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-22 15:36       ` Thomas Schmitt
2014-01-25 16:27       ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413645726316204936@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).