From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XlD61-00081F-69 for mharc-grub-devel@gnu.org; Mon, 03 Nov 2014 03:34:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlD5p-0007x6-Bd for grub-devel@gnu.org; Mon, 03 Nov 2014 03:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlD5e-0005AC-SS for grub-devel@gnu.org; Mon, 03 Nov 2014 03:34:29 -0500 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]:62656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlD5e-00059s-Kw for grub-devel@gnu.org; Mon, 03 Nov 2014 03:34:18 -0500 Received: by mail-pd0-f172.google.com with SMTP id r10so11141982pdi.31 for ; Mon, 03 Nov 2014 00:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id; bh=bUb7XgDJX7iHQHrg9npPeBBMOPNBz9iRQo9aX5ArZfQ=; b=rE0oNftHmSyLJOjYlgszk+vCNoJQnMsCy9l1467KPKROVaF4FQ92KBfcf+w8CzYDBg n+oI7Cdp4Zz/KfpX31dWchXEFnXAF+N8ZuRnWrqfArmWFTrHJlOtgzeczvNcLmB7795/ jgg9DEuAdsGFtTPO7TtpeX4ogh6wV/GKJ47L0D486QEesfD5MU0C2wbrXlOfPDsvXkWo 5MYeciq+CZ1XAz3xSMDQ/3bD+OJ08gx1u8MUXPG3LwwUeJklATQKpvzevnR1rUldvbuc nrEFbo7pydyYiqGWaUNlK5apJY7ew/vbDDku0KvAOraYE28zfiHLdP2jK9cqQLjjFiO5 2Ihw== X-Received: by 10.68.88.225 with SMTP id bj1mr2137529pbb.118.1415003657541; Mon, 03 Nov 2014 00:34:17 -0800 (PST) Received: from localhost.localdomain ([130.57.30.250]) by mx.google.com with ESMTPSA id mx7sm16479715pdb.65.2014.11.03.00.34.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 00:34:17 -0800 (PST) Sender: =?UTF-8?B?5by15paH6I+v?= From: Michael Chang To: grub-devel@gnu.org Subject: [PATCH] icmp6 fix no respond to neighbor solicit message Date: Mon, 3 Nov 2014 16:27:45 +0800 Message-Id: <1415003265-13848-1-git-send-email-mchang@suse.com> X-Mailer: git-send-email 1.7.3.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 08:34:38 -0000 The structure size used in grub_netbuff_pull to get the pointer to option header is apparently wrong, which leads to subsequent range check failed and therefore not responding to any neighbor solicit message in my testing. --- grub-core/net/icmp6.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/grub-core/net/icmp6.c b/grub-core/net/icmp6.c index bbc9020..796d549 100644 --- a/grub-core/net/icmp6.c +++ b/grub-core/net/icmp6.c @@ -205,7 +205,7 @@ grub_net_recv_icmp6_packet (struct grub_net_buff *nb, if (ttl != 0xff) break; nbh = (struct neighbour_solicit *) nb->data; - err = grub_netbuff_pull (nb, sizeof (struct router_adv)); + err = grub_netbuff_pull (nb, sizeof (*nbh)); if (err) { grub_netbuff_free (nb); -- 1.7.3.4