grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: 755256@bugs.debian.org, grub-devel@gnu.org
Subject: Re: [PATCH] grub-install: Include all decompressor modules in pvxen core image.
Date: Sun, 30 Nov 2014 13:34:23 +0000	[thread overview]
Message-ID: <1417354463.2372.27.camel@hellion.org.uk> (raw)
In-Reply-To: <1417348279.2372.20.camel@hellion.org.uk>

On Sun, 2014-11-30 at 11:51 +0000, Ian Campbell wrote:
> On Sun, 2014-11-30 at 14:31 +0300, Andrei Borzenkov wrote:
> > if [ x$grub_platform = xxen ]; then
> >   insmod xzio
> > fi
> 
> I think that could work.

Indeed it does, so how about this instead of the patch at the start of
the thread?

From f4199776eca80dfad4e9378a01ddb5866face3d7 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ijc@debian.org>
Date: Sun, 30 Nov 2014 12:12:52 +0000
Subject: [PATCH] Arrange to insmod xzio when booting a kernel as a Xen guest

This is needed in case the Linux kernel is compiled with CONFIG_KERNEL_XZ
rather than CONFIG_KERNEL_GZ (gzio is already loaded by grub.cfg).

Signed-off-by: Ian Campbell <ijc@debian.org>

Patch-Name: insmod-xzio-on-xen.patch
---
 util/grub.d/10_linux.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in
index 79fa03a..86e35f2 100644
--- a/util/grub.d/10_linux.in
+++ b/util/grub.d/10_linux.in
@@ -150,6 +150,7 @@ linux_entry ()
   fi
 
   echo "	insmod gzio" | sed "s/^/$submenu_indentation/"
+  echo "	if [ x\$grub_platform = xxen ]; then insmod xzio; insmod lzopio; fi" | sed "s/^/$submenu_indentation/"
 
   if [ x$dirname = x/ ]; then
     if [ -z "${prepare_root_cache}" ]; then
-- 
2.1.3





  parent reply	other threads:[~2014-11-30 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  8:33 [PATCH] grub-install: Include all decompressor modules in pvxen core image Ian Campbell
2014-11-28 17:09 ` Andrei Borzenkov
2014-11-28 17:25   ` Ian Campbell
2014-11-30 11:31     ` Andrei Borzenkov
2014-11-30 11:51       ` Ian Campbell
2014-11-30 11:52         ` Ian Campbell
2014-11-30 13:34         ` Ian Campbell [this message]
2014-12-07 17:18           ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-12-07 17:26             ` Andrei Borzenkov
2014-12-07 21:53               ` Vladimir 'φ-coder/phcoder' Serbinenko
2016-02-12 16:28               ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417354463.2372.27.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=755256@bugs.debian.org \
    --cc=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).