From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ZEwiY-0004FE-O6
	for mharc-grub-devel@gnu.org; Tue, 14 Jul 2015 05:41:38 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=630a0ae6d=Ian.Campbell@citrix.com>)
	id 1ZEwiV-0004AI-LL
	for grub-devel@gnu.org; Tue, 14 Jul 2015 05:41:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=630a0ae6d=Ian.Campbell@citrix.com>)
	id 1ZEwiR-0002zz-Ba
	for grub-devel@gnu.org; Tue, 14 Jul 2015 05:41:35 -0400
Received: from smtp.citrix.com ([66.165.176.89]:19006)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=630a0ae6d=Ian.Campbell@citrix.com>)
	id 1ZEwiR-0002zn-8Q
	for grub-devel@gnu.org; Tue, 14 Jul 2015 05:41:31 -0400
X-IronPort-AV: E=Sophos;i="5.15,470,1432598400"; d="scan'208";a="280734808"
Message-ID: <1436866888.25044.47.camel@citrix.com>
Subject: Re: [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support
From: Ian Campbell <ian.campbell@citrix.com>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Date: Tue, 14 Jul 2015 10:41:28 +0100
In-Reply-To: <20150714065317.36dc83aa@opensuse.site>
References: <=fu.wei@linaro.org>
	<1436777640-31871-1-git-send-email-fu.wei@linaro.org>
	<1436777640-31871-3-git-send-email-fu.wei@linaro.org>
	<20150714065317.36dc83aa@opensuse.site>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 66.165.176.89
Cc: grub-devel@gnu.org, xen-devel@lists.xensource.com, jcm@redhat.com,
	stefano.stabellini@eu.citrix.com, phcoder@gmail.com,
	leif.lindholm@linaro.org, ryan.harkin@linaro.org,
	linaro-uefi@lists.linaro.org, fu.wei@linaro.org
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2015 09:41:36 -0000

On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote:
> > +if [ "x$machine" != xaarch64 ]; then
> > +	multiboot_cmd="multiboot"
> > +	module_cmd="module"
> > +else
> > +	multiboot_cmd="xen_hypervisor"
> > +	module_cmd="xen_module"
> > +fi
> > +
> 
> Strictly speaking, this is boot-time decision. As mentioned by
> Vladimir, better would be to provide alias xen_hypervisor and
> xen_module in multiboot for platforms supporting Xen (is MIPS really
> supported?) and use it consistently.

I had been thinking of this the other way around, e.g. on platforms
which support Xen but not multiboot1 "multiboot" would be added as an
alias for xen_hypervisor.

However so long as grub-mkconfig (via 20_linux_xen) work for everyone
and that peoples existing hand-crafted x86/multiboot/Xen grub.cfg's
continue to work then I think having the alias go either way would be
fine.

BTW I had been going to suggest a function at the grub.cfg level which
dispatched to the correct command, but I suppose an actual alias is
better.

Ian.