From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZPRy6-0005cu-Td for mharc-grub-devel@gnu.org; Wed, 12 Aug 2015 05:05:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRy3-0005aP-Jn for grub-devel@gnu.org; Wed, 12 Aug 2015 05:05:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPRxz-0007R6-KB for grub-devel@gnu.org; Wed, 12 Aug 2015 05:05:03 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:25208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPRxz-0007PM-GV for grub-devel@gnu.org; Wed, 12 Aug 2015 05:04:59 -0400 X-IronPort-AV: E=Sophos;i="5.15,660,1432598400"; d="scan'208";a="293671171" Message-ID: <1439370297.9747.318.camel@citrix.com> Subject: Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files From: Ian Campbell To: Daniel Kiper , , Date: Wed, 12 Aug 2015 10:04:57 +0100 In-Reply-To: <1437402954-7375-2-git-send-email-daniel.kiper@oracle.com> References: <1437402954-7375-1-git-send-email-daniel.kiper@oracle.com> <1437402954-7375-2-git-send-email-daniel.kiper@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-DLP: MIA1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: jgross@suse.com, keir@xen.org, andrew.cooper3@citrix.com, stefano.stabellini@eu.citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, wei.liu2@citrix.com, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2015 09:05:04 -0000 (Having written the below I see too late that this is a grub patch not a Xen one, a tag in the subject for such cross posted patches would be useful please. Anyway, my opinion counts for very little in this context but I leave it below since already I wrote it. I notice that xen.git#.gitignore _does_ list *.rej, which I think is wrong...) On Mon, 2015-07-20 at 16:35 +0200, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper At least *.rej and perhaps *.orig are indicative of a failed patch application, I think I want them to appear in "git status". By way of comparison Linux's .gitignore includes *.orig but not *.rej and Qemu's includes neither. So nack to the addition of *.rej from me. I'm more or less ambivalent about *.orig. > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 18ab8e8..6d25d39 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -147,6 +147,7 @@ mod-*.c > missing > netboot_test > *.o > +*.orig > *.a > ohci_test > partmap_test > @@ -160,9 +161,11 @@ po/stamp-po > printf_test > priority_queue_unit_test > pseries_test > +*.rej > stamp-h > stamp-h1 > stamp-h.in > +*.swp > symlist.c > symlist.h > trigtables.c