From: Thomas Huth <thuth@redhat.com>
To: grub-devel@gnu.org
Subject: [PATCH] menu_entry: Disable cursor during update_screen()
Date: Fri, 29 Jan 2016 15:26:58 +0100 [thread overview]
Message-ID: <1454077618-18986-1-git-send-email-thuth@redhat.com> (raw)
When running grub in a VGA console of a KVM pseries guest on PowerPC,
you can see the cursor sweeping over the whole line when entering a
character in editor mode. This is visible because grub always refreshes
the whole line when entering a character in editor mode, and drawing
characters is quite a slow operation with the firmware used for the
powerpc pseries guests (SLOF).
To avoid this ugliness, the cursor should be disabled when refreshing
the screen contents during update_screen().
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
| 4 ++++
1 file changed, 4 insertions(+)
--git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_entry.c
index 62c7e16..68359eb 100644
--- a/grub-core/normal/menu_entry.c
+++ b/grub-core/normal/menu_entry.c
@@ -250,6 +250,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen,
mode = ALL_LINES;
}
+ grub_term_setcursor (term_screen->term, 0);
+
if (mode != NO_LINE)
{
/* Draw lines. This code is tricky, because this must calculate logical
@@ -357,6 +359,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen,
}
+ grub_term_setcursor (term_screen->term, 1);
+
grub_term_refresh (term_screen->term);
}
--
1.8.3.1
next reply other threads:[~2016-01-29 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 14:26 Thomas Huth [this message]
2016-01-30 7:33 ` [PATCH] menu_entry: Disable cursor during update_screen() Andrei Borzenkov
2016-01-31 15:02 ` Thomas Huth
2016-02-13 7:41 ` Andrei Borzenkov
2016-02-15 10:23 ` Thomas Huth
2016-02-12 8:19 ` Thomas Huth
2016-02-22 7:00 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454077618-18986-1-git-send-email-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).