From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aPA11-0000IS-HD for mharc-grub-devel@gnu.org; Fri, 29 Jan 2016 09:27:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPA0v-0000Hh-SA for grub-devel@gnu.org; Fri, 29 Jan 2016 09:27:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPA0q-0003YH-TB for grub-devel@gnu.org; Fri, 29 Jan 2016 09:27:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPA0q-0003Xp-Nw for grub-devel@gnu.org; Fri, 29 Jan 2016 09:27:00 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 493E313A6A for ; Fri, 29 Jan 2016 14:27:00 +0000 (UTC) Received: from thh440s.str.redhat.com. (dhcp-192-192.str.redhat.com [10.33.192.192]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0TEQxav017215 for ; Fri, 29 Jan 2016 09:26:59 -0500 From: Thomas Huth To: grub-devel@gnu.org Subject: [PATCH] menu_entry: Disable cursor during update_screen() Date: Fri, 29 Jan 2016 15:26:58 +0100 Message-Id: <1454077618-18986-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 14:27:09 -0000 When running grub in a VGA console of a KVM pseries guest on PowerPC, you can see the cursor sweeping over the whole line when entering a character in editor mode. This is visible because grub always refreshes the whole line when entering a character in editor mode, and drawing characters is quite a slow operation with the firmware used for the powerpc pseries guests (SLOF). To avoid this ugliness, the cursor should be disabled when refreshing the screen contents during update_screen(). Signed-off-by: Thomas Huth --- grub-core/normal/menu_entry.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_entry.c index 62c7e16..68359eb 100644 --- a/grub-core/normal/menu_entry.c +++ b/grub-core/normal/menu_entry.c @@ -250,6 +250,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, mode = ALL_LINES; } + grub_term_setcursor (term_screen->term, 0); + if (mode != NO_LINE) { /* Draw lines. This code is tricky, because this must calculate logical @@ -357,6 +359,8 @@ update_screen (struct screen *screen, struct per_term_screen *term_screen, } + grub_term_setcursor (term_screen->term, 1); + grub_term_refresh (term_screen->term); } -- 1.8.3.1