From: Julien Grall <julien.grall@linaro.org>
To: grub-devel@gnu.org
Cc: ian.campbell@citrix.com, steve.capper@arm.com, phcoder@gmail.com,
Julien Grall <julien.grall@linaro.org>,
xen-devel@lists.xen.org, stefano.stabellini@citrix.com,
fu.wei@linaro.org
Subject: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64
Date: Fri, 19 Feb 2016 16:28:52 +0000 [thread overview]
Message-ID: <1455899332-9054-1-git-send-email-julien.grall@linaro.org> (raw)
Xen is currently crashing because of malformed compatible property for
the boot module. This is because the property string is not
null-terminated as requested by the ePAR spec.
---
grub-core/loader/arm64/xen_boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c
index a914eb8..8ae43d7 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -156,7 +156,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, void *xen_boot_fdt)
grub_fdt_add_subnode (xen_boot_fdt, chosen_node, module_name);
retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "compatible",
- MODULE_CUSTOM_COMPATIBLE, sizeof(MODULE_CUSTOM_COMPATIBLE) - 1);
+ MODULE_CUSTOM_COMPATIBLE, sizeof(MODULE_CUSTOM_COMPATIBLE));
if (retval)
return grub_error (GRUB_ERR_IO, "failed to update FDT");
--
1.9.1
next reply other threads:[~2016-02-19 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 16:28 Julien Grall [this message]
2016-02-22 9:29 ` [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64 Fu Wei
2016-02-23 10:00 ` Ian Campbell
2016-02-23 14:16 ` Fu Wei
2016-02-27 17:05 ` Andrei Borzenkov
2016-07-26 8:40 ` Fu Wei
2016-03-30 15:52 ` Julien Grall
2016-03-30 17:10 ` Fu Wei
2016-11-03 14:19 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455899332-9054-1-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=fu.wei@linaro.org \
--cc=grub-devel@gnu.org \
--cc=ian.campbell@citrix.com \
--cc=phcoder@gmail.com \
--cc=stefano.stabellini@citrix.com \
--cc=steve.capper@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).