grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: grub-devel@gnu.org
Cc: Alexander Graf <agraf@suse.de>
Subject: [RFC 0/3] Add/use helper functions for finding UEFI config tables
Date: Tue,  1 Mar 2016 17:41:40 +0000	[thread overview]
Message-ID: <1456854103-12095-1-git-send-email-leif.lindholm@linaro.org> (raw)

(Triggered by Alex's recent patches)

There are a few places in the code manually iterating across the
config tables provided through the UEFI system table. This set
implements a common search function and converts some existing
functions to use it.

I have not yet converted commands/efi/loadbios.c given that it
searches for multiple things in one go. Would be a trivial change.

Also, for cleanliness of call-sites a better approach may be to macroize
the function so that it was possible to simply go:
  ptr = grub_efi_find_config_table(MY_VERY_SPECIAL_GUID);
This was not my preference, since that hides the fact that the
underlying datatype is a 128-bit struct.

Leif Lindholm (3):
  efi: add configuration table search function
  arm64 linux loader: use grub_efi_find_config_table to find DT
  acpi: use grub_efi_find_config_table to find tables

 grub-core/kern/efi/acpi.c    | 28 ++++------------------------
 grub-core/kern/efi/efi.c     | 18 ++++++++++++++++++
 grub-core/loader/arm64/fdt.c | 16 +---------------
 include/grub/efi/efi.h       |  3 +++
 4 files changed, 26 insertions(+), 39 deletions(-)

-- 
2.1.4



             reply	other threads:[~2016-03-01 17:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 17:41 Leif Lindholm [this message]
2016-03-01 17:41 ` [RFC 1/3] efi: add configuration table search function Leif Lindholm
2016-03-01 20:08   ` Andrei Borzenkov
2016-03-01 20:13     ` Vladimir 'phcoder' Serbinenko
2016-03-01 20:28       ` Leif Lindholm
2016-03-10 20:05         ` Vladimir 'phcoder' Serbinenko
2016-03-01 20:14     ` Leif Lindholm
2016-03-01 17:41 ` [RFC 2/3] arm64 linux loader: use grub_efi_find_config_table to find DT Leif Lindholm
2016-03-01 17:41 ` [RFC 3/3] acpi: use grub_efi_find_config_table to find tables Leif Lindholm
2016-03-01 18:38 ` [RFC 0/3] Add/use helper functions for finding UEFI config tables Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456854103-12095-1-git-send-email-leif.lindholm@linaro.org \
    --to=leif.lindholm@linaro.org \
    --cc=agraf@suse.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).