grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: grub-devel@gnu.org, xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, arvidjaar@gmail.com,
	eric.snowberg@oracle.com,  jgross@suse.com,
	konrad.wilk@oracle.com, phcoder@gmail.com,
	seth.goldberg@oracle.com, tsoome@me.com
Subject: [MULTIBOOT2 DOC PATCH v3 02/13] multiboot2: Replace u_virt with u32
Date: Tue,  6 Dec 2016 23:52:50 +0100	[thread overview]
Message-ID: <1481064781-16949-3-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1481064781-16949-1-git-send-email-daniel.kiper@oracle.com>

u_virt may sometimes confuse reader especially if description says something
completely different. Additionally, GRUB multiboot2 implementation does not
use u_virt anywhere. So, replace it with basic well defined and used in
implementation u32 type.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 doc/multiboot.texi |   15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/doc/multiboot.texi b/doc/multiboot.texi
index 2bda9b7..7d12ab0 100644
--- a/doc/multiboot.texi
+++ b/doc/multiboot.texi
@@ -299,9 +299,6 @@ little-endian, u32 is coded in little-endian.
 The type of unsigned 64-bit data. Because the target architecture is
 little-endian, u64 is coded in little-endian.
 
-@item u_virt
-The type of unsigned data of the same size as target architecture virtual address size.
-
 @end table
 
 
@@ -407,7 +404,7 @@ and @samp{header_length}), must have a 32-bit unsigned sum of zero.
 
 @node Header tags
 @subsection General tag structure
-Tags constitutes a buffer of structures following each other padded on @samp{u_virt} size.
+Tags constitutes a buffer of structures following each other padded on @samp{u32} size.
 Every structure has following format:
 
 @example
@@ -460,10 +457,10 @@ actually be present. E.g. on a videoless system even if you requested tag
 u16     | type = 2          |
 u16     | flags             |
 u32     | size              |
-u_virt  | header_addr       |
-u_virt  | load_addr         |
-u_virt  | load_end_addr     |
-u_virt  | bss_end_addr      |
+u32     | header_addr       |
+u32     | load_addr         |
+u32     | load_end_addr     |
+u32     | bss_end_addr      |
         +-------------------+
 @end group
 @end example
@@ -511,7 +508,7 @@ assumes that no bss segment is present.
 u16     | type = 3          |
 u16     | flags             |
 u32     | size              |
-u_virt  | entry_addr        |
+u32     | entry_addr        |
         +-------------------+
 @end group
 @end example
-- 
1.7.10.4



  parent reply	other threads:[~2016-12-06 22:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 22:52 [MULTIBOOT2 DOC PATCH v3 00/13] multiboot2: Update documentation Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 01/13] multiboot2: Replace u_phys with u32 Daniel Kiper
2016-12-10 17:23   ` Andrei Borzenkov
2016-12-12 13:48     ` Daniel Kiper
2016-12-06 22:52 ` Daniel Kiper [this message]
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 03/13] multiboot2: Rename Multiboot to Multiboot2 Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 04/13] multiboot2: Replace redundant if with the Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 05/13] multiboot2: Clarify meaning of information request header tag Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 06/13] multiboot2: Fix description of EFI boot services tag Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 07/13] multiboot2: Add description of support for EFI boot services Daniel Kiper
2016-12-07 14:33   ` Konrad Rzeszutek Wilk
2016-12-07 18:21     ` Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 08/13] multiboot2: Add description of EFI image handle tags Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 09/13] multiboot2: Add description of support for relocatable images Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 10/13] multiboot2: Say that memory maps may not be available on EFI platforms Daniel Kiper
2016-12-06 22:52 ` [MULTIBOOT2 DOC PATCH v3 11/13] multiboot2: Add C structure members alignment and padding consideration section Daniel Kiper
2016-12-06 22:53 ` [MULTIBOOT2 DOC PATCH v3 12/13] multiboot2: Add me to authors Daniel Kiper
2016-12-06 22:53 ` [MULTIBOOT2 DOC PATCH v3 13/13] multiboot2: Bump version to 2.0 Daniel Kiper
2016-12-07  3:45 ` [MULTIBOOT2 DOC PATCH v3 00/13] multiboot2: Update documentation Konrad Rzeszutek Wilk
2016-12-07 11:26   ` Daniel Kiper
2016-12-07 14:34     ` Konrad Rzeszutek Wilk
2016-12-07 18:24       ` Daniel Kiper
2016-12-09 12:57 ` Daniel Kiper
2016-12-14 13:21   ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481064781-16949-3-git-send-email-daniel.kiper@oracle.com \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=arvidjaar@gmail.com \
    --cc=eric.snowberg@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=phcoder@gmail.com \
    --cc=seth.goldberg@oracle.com \
    --cc=tsoome@me.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).