From: Dennis Chen <dennis.chen@arm.com>
To: <grub-devel@gnu.org>
Cc: <nd@arm.com>, Dennis Chen <dennis.chen@arm.com>
Subject: [PATCH] video: Allow to set pure 'text' mode in case of EFI
Date: Fri, 13 Oct 2017 10:18:17 +0800 [thread overview]
Message-ID: <1507861097-16783-1-git-send-email-dennis.chen@arm.com> (raw)
Current code doesn't accept a pure text mode when booting
from UEFI firmware on i386 platform, this will result in
below error message even we already have 'set gfxpayload=text'
configured: "no suitable video mode found". This often happens
when we boot a VM which UEFI firmware doesn't include 'suitable'
video modes.
UEFI spec doesn't tell it will not support pure text mode explicitly,
if GRUB2 strictly forbid this mode that means UEFI has to provide
a so-called 'suitable video mode'.
Signed-off-by: Dennis Chen <dennis.chen@arm.com>
---
grub-core/loader/i386/linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/loader/i386/linux.c b/grub-core/loader/i386/linux.c
index 5fdfea3..8cf1086 100644
--- a/grub-core/loader/i386/linux.c
+++ b/grub-core/loader/i386/linux.c
@@ -49,7 +49,7 @@ GRUB_MOD_LICENSE ("GPLv3+");
#include <grub/efi/efi.h>
#define HAS_VGA_TEXT 0
#define DEFAULT_VIDEO_MODE "auto"
-#define ACCEPTS_PURE_TEXT 0
+#define ACCEPTS_PURE_TEXT 1
#elif defined (GRUB_MACHINE_IEEE1275)
#include <grub/ieee1275/ieee1275.h>
#define HAS_VGA_TEXT 0
--
2.7.4
reply other threads:[~2017-10-13 6:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507861097-16783-1-git-send-email-dennis.chen@arm.com \
--to=dennis.chen@arm.com \
--cc=grub-devel@gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).