grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: [PATCH] missed grub_free in icon_manager
Date: Thu, 07 Mar 2013 12:53:54 +0400	[thread overview]
Message-ID: <1572194.u8tUiaEOFG@icedphoenix> (raw)

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Missed grub_free in gfxmenu/icon_manager.c

If I'm not mistaken, it should be there.

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub-2.00-missed-grub-free.patch --]
[-- Type: text/x-patch, Size: 463 bytes --]

diff -Naur grub-2.00/grub-core/gfxmenu/icon_manager.c grub-new/grub-core/gfxmenu/icon_manager.c
--- grub-2.00/grub-core/gfxmenu/icon_manager.c	2012-02-08 16:41:41.000000000 +0400
+++ grub-new/grub-core/gfxmenu/icon_manager.c	2013-03-07 12:50:15.805798204 +0400
@@ -213,6 +213,7 @@
       icondir = grub_env_get ("icondir");
       if (icondir)
 	icon = try_loading_icon (mgr, icondir, class_name);
+      grub_free(icondir);
     }
 
   /* No icon was found.  */

             reply	other threads:[~2013-03-07  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  8:53 Vladimir Testov [this message]
2013-03-07  9:05 ` [PATCH] missed grub_free in icon_manager Vladimir 'φ-coder/phcoder' Serbinenko
2013-03-07  9:07   ` Vladimir 'φ-coder/phcoder' Serbinenko
  -- strict thread matches above, loose matches on Subject: below --
2013-03-07 10:32 Vladimir Testov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1572194.u8tUiaEOFG@icedphoenix \
    --to=vladimir.testov@rosalab.ru \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).