From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors.
Date: Thu, 07 Mar 2013 08:22:57 +0400 [thread overview]
Message-ID: <2003250.qxhAB4PHaT@icedphoenix> (raw)
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
>This loses original OOM error if it was returned. May be make it return
>true/false and check if grub_errno is set on false. Not sure.
>
>Do you have any real problem to solve? I wonder if these errors are
>visible to user at all; if not, setting them does not really buy
>anything.
The original error is not beeing processed at all in the current state.
So if we have error in global option or in component's name - the error is displayed.
But if we have error in component's option - (in current state) nothing is displayed and the option is just beeing ignored.
With this patch the error will be displayed in all cases.
Andrey, maybe you should try to compile GRUB with the patch or read source
code more carefully before making conclusions? Or should I sent you screenshot
with displaying of the error? Or you just don't know how the theme file is
beeing parsed?
Please, try to be more concrete. :)
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
[-- Attachment #2: Type: text/html, Size: 4976 bytes --]
next reply other threads:[~2013-03-07 4:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 4:22 Vladimir Testov [this message]
2013-03-07 6:03 ` [PATCH] gfxterm: check elements' properties and hadle errors Andrey Borzenkov
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 7:46 Vladimir Testov
2013-03-07 6:29 Vladimir Testov
2013-03-04 11:27 Vladimir Testov
2013-03-06 18:05 ` Andrey Borzenkov
2013-03-07 7:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2003250.qxhAB4PHaT@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).