From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UDSMG-0007Vx-9C for mharc-grub-devel@gnu.org; Wed, 06 Mar 2013 23:23:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDSMD-0007VK-4P for grub-devel@gnu.org; Wed, 06 Mar 2013 23:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDSMB-0008Tl-Tx for grub-devel@gnu.org; Wed, 06 Mar 2013 23:23:05 -0500 Received: from collab.rosalab.ru ([217.199.216.181]:47287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDSMB-0008TA-Hj for grub-devel@gnu.org; Wed, 06 Mar 2013 23:23:03 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by collab.rosalab.ru (Postfix) with ESMTP id B650229C2EB for ; Thu, 7 Mar 2013 08:23:01 +0400 (MSK) X-Virus-Scanned: amavisd-new at rosalab.ru Received: from collab.rosalab.ru ([127.0.0.1]) by localhost (collab.rosalab.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g6xxU7j3ooOd for ; Thu, 7 Mar 2013 08:23:01 +0400 (MSK) Received: from icedphoenix.localnet (unknown [10.168.1.56]) by collab.rosalab.ru (Postfix) with ESMTPSA id EE67629C291 for ; Thu, 7 Mar 2013 08:23:00 +0400 (MSK) From: Vladimir Testov To: grub-devel@gnu.org Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors. Date: Thu, 07 Mar 2013 08:22:57 +0400 Message-ID: <2003250.qxhAB4PHaT@icedphoenix> User-Agent: KMail/4.9.4 (Linux/3.5.0-23-generic; KDE/4.9.4; x86_64; ; ) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart4195033.3LP0z7UPfX" Content-Transfer-Encoding: 7Bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 217.199.216.181 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 04:23:07 -0000 This is a multi-part message in MIME format. --nextPart4195033.3LP0z7UPfX Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" >This loses original OOM error if it was returned. May be make it return >true/false and check if grub_errno is set on false. Not sure. > >Do you have any real problem to solve? I wonder if these errors are >visible to user at all; if not, setting them does not really buy >anything. The original error is not beeing processed at all in the current state. So if we have error in global option or in component's name - the error is displayed. But if we have error in component's option - (in current state) nothing is displayed and the option is just beeing ignored. With this patch the error will be displayed in all cases. Andrey, maybe you should try to compile GRUB with the patch or read source code more carefully before making conclusions? Or should I sent you screenshot with displaying of the error? Or you just don't know how the theme file is beeing parsed? Please, try to be more concrete. :) -- With best regards, _______________________________ Vladimir Testov, ROSA Laboratory. www.rosalab.ru --nextPart4195033.3LP0z7UPfX Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

>This loses original OOM error if it was returned. May be make it return

>true/false and check if grub_errno is set on false. Not sure.

>Do you have any real problem to solve? I wonder if these errors are

>visible to user at all; if not, setting them does not really buy

>anything.

The original error is not beeing processed at all in the current state.

So if we have error in global option or in component's name - the error is displayed.

But if we have error in component's option - (in current state) nothing is displayed and the option is just beeing ignored.

With this patch the error will be displayed in all cases.

Andrey, maybe you should try to compile GRUB with the patch or read source code more carefully before making conclusions? Or should I sent you screenshot with displaying of the error? Or you just don't know how the theme file is beeing parsed?

Please, try to be more concrete. :)

With best regards,

_______________________________

Vladimir Testov, ROSA Laboratory.

www.rosalab.ru

--nextPart4195033.3LP0z7UPfX--