Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: variable hooks & global variables
Date: Thu, 3 Jan 2008 16:03:11 +0100	[thread overview]
Message-ID: <20080103150311.GA20790@thorin> (raw)


When you set a variable hook (grub_register_variable_hook), this hook isn't
preserved after someone (e.g. configfile command) opens a new context
(grub_env_context_open), unless the variable has been set as global
(grub_env_export).

Is this what we want?

The only current user of variable hooks is "root" variable, and that hook
contains a sanity check that seems to be more suitable for global scope.

The color-related variables for which I wanted to add hooks would also
like to keep their hooks across contexts.

One option is to export these variables, or to modify grub_env_context_open()
to preserve hooks as well as exported variables.  I'm more inclined for the
latter.

Comments?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)



             reply	other threads:[~2008-01-03 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 15:03 Robert Millan [this message]
2008-01-03 15:05 ` variable hooks & global variables Robert Millan
2008-01-03 15:31   ` Robert Millan
2008-01-05  1:22   ` Yoshinori K. Okuji
2008-01-05 12:03     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103150311.GA20790@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox