Re: [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix)

[Colin D Bennett <colin@gibibit.com>]

[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]

On Fri, 2 Jan 2009 16:44:49 -0600
"Jerone Young" <jerone@gmail.com> wrote:

> I just paid attention to this (sorry). So everything seems fine. But
> the dependency on  a proprietary java stack  to generate fonts isn't
> good. Does it happen to work with gcc java ?

The font tool does work with gcj (gcc's Java compiler).  I just had to
make a trivial change (see attached) since gcj 4.3.2 does not yet
implement the String(byte[], Charset) constructor.

Regards,
Colin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fonttool-gcj-2009-01-03.patch --]
[-- Type: text/x-patch, Size: 578 bytes --]

=== modified file 'util/fonttool/src/org/gnu/grub/fonttool/PFF2Loader.java'
--- util/fonttool/src/org/gnu/grub/fonttool/PFF2Loader.java	2008-08-31 04:38:54 +0000
+++ util/fonttool/src/org/gnu/grub/fonttool/PFF2Loader.java	2009-01-03 16:40:26 +0000
@@ -180,7 +180,7 @@
     private String openSection() throws IOException {
         byte[] b = new byte[4];
         f.readFully(b);
-        return new String(b, Charset.forName("US-ASCII"));
+        return new String(b, "US-ASCII");
     }
 
     private String readCompleteSectionAsString() throws IOException {


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]