From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean <bean123ch@gmail.com>)
Date: Mon, 29 Jun 2009 15:50:40 +0200 [thread overview]
Message-ID: <20090629135040.GD20463@thorin> (raw)
In-Reply-To: <ca0f59980906280759p5bf2c0b1x9af217b5def5dbe@mail.gmail.com>
On Sun, Jun 28, 2009 at 10:59:31PM +0800, Bean wrote:
> Hi,
>
> Actually that's not the cause. The call order is right, it's just that
> the normal reader would clear screen and print an header in its init
> function. If you want to change it, you can move those code to the
> menu viewer, but I guess Colin is about to commit his menu viewer
> patch, I think it would be better to leave it alone for now to
> minimize code conflict.
Uhm I just noticed if you convert grub_cls() to a stub, you'll see the
menu header being printed twice. Could this be related?
If we're printing the header a second time unnecessarily, we could just
remove the first one.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
prev parent reply other threads:[~2009-06-29 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1M0LDL-0007Vc-4D@cvs.savannah.gnu.org>
2009-06-28 12:35 ` regression in hiddenmenu (Re: [2158] 2009-05-02 Bean <bean123ch@gmail.com>) Robert Millan
2009-06-28 13:48 ` Marco Gerards
2009-06-28 14:52 ` Robert Millan
2009-06-28 14:59 ` Bean
2009-06-29 13:50 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629135040.GD20463@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox