Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files
Date: Wed, 12 Aug 2009 02:38:00 +0200	[thread overview]
Message-ID: <20090812003800.GC8561@thorin> (raw)
In-Reply-To: <d7ead6de0908110633s234ba1a1s3be4cb9adc5b5af2@mail.gmail.com>

On Tue, Aug 11, 2009 at 03:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. A bug was filed that embedding code in grub-setup.c was
> ignoring partmap metadata which could cause its overwriting. To avoid
> usage of metadata and because of upcoming sunpc embedding support I
> propose to move embedding to partmap/*.c. For this I devised an
> interface which enables future reusage of embedding for other too if
> necessary.

Can this go in util/i386/pc/ instead?  This is basicaly ad-hoc code and
doesn't seem very meaningful in generic partmap/*.c.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2009-08-12  0:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11 13:33 [RFT,PATCH] Move embedding to appropriate partmap files Vladimir 'phcoder' Serbinenko
2009-08-12  0:38 ` Robert Millan [this message]
2009-08-12  9:39   ` Michal Suchanek
2009-08-13 20:34     ` Robert Millan
2009-08-12 12:52   ` Vladimir 'phcoder' Serbinenko
2009-08-13 20:37     ` Robert Millan
2009-08-13 20:49       ` Seth Goldberg
2009-08-13 20:53       ` Vladimir 'phcoder' Serbinenko
2009-08-13 21:05         ` Robert Millan
2009-10-16 10:58           ` Vladimir 'phcoder' Serbinenko
2009-10-16 21:07             ` Robert Millan
2009-10-16 21:12               ` Vladimir 'phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090812003800.GC8561@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox